lint fixes

[mts1715]

• fixed problems that was found by flow cadence lint.
• added lint stage before test stage in the CI workflow

---

Update: problem bellow was solved in onflow/cadence-tools#586 .

But some problems were left unresolved due to a bug with the linter:

var out: [UInt8] = []    // type annotation is redundant, type can be inferred
var out = []             // cannot infer type: requires an explicit type annotation. add an explicit type annotation to resolve the ambiguity
var out = [] as [UInt8]  // static cast is redundant

Also, it's impossible to use a long string template across multiple lines, so in order to prevent long lines, it should be written like this:

panic("Deposit token type \(self.depositVaultType.identifier) has not been onboarded to the VM bridge - "
                .concat("Ensure the Cadence token type is associated with an EVM contract via the VM bridge"))

But the linter suggests: string concatenation can be replaced with string template

[SupunS]

Looks good overall!
Left a few suggestions for using the type-annotation over casting/conversion.

[SupunS]

Wonder if it would make sense to make the nBits parameter UInt type, instead of Int. I don't really know where this wordToUIntN is used, so might depends on the use-cases.

If we could do that, then it's possible to just keep the type-annotation for the mask variable (LHS), and remove all the castings/conversions from the RHS of the assignment. e.g:

Suggested change

	let mask = (1 as UInt << UInt(nBits)) - 1
	let mask: UInt = (1 << nBits) - 1

[mts1715]

Wonder if it would make sense to make the nBits parameter UInt type, instead of Int. I don't really know where this wordToUIntN is used, so might depends on the use-cases.

this code is inside the fun:

            fun wordToUIntN(_ w: [UInt8], _ nBits: Int): UInt {
                let full = wordToUInt(w)
                if nBits >= 256 { return full }
                let mask: UInt = (1 << UInt(nBits)) - 1
                return full & mask
            }

so it should return UInt

[SupunS]

Changing the parameter nBits: Int to nBits: UInt wouldn't impact the return type. It seems all call-sites to this function pass a number-literal (e.g: wordToUIntN(s0w[0], 160) and wordToUIntN(words(liqRes!.data)[0], 128)), so that change would be compatible with the call-sites too.

[turbolent]

Nice! Thanks for cleaning this up

[turbolent]

Why where the authorizations added here? These changes don't seem to be related to fixing linting errors, so maybe propose them in a separate PR

[turbolent]

Same here: Maybe propose these changes unrelated to fixing linter warnings in a separate PR

[turbolent]

Same here: Maybe propose these changes unrelated to fixing linter warnings in a separate PR