Repository navigation
test: raise last error when http code retry helper exhausts retries - #130
Open
dvacca-onfido wants to merge 1 commit into
Open
dvacca-onfido wants to merge 1 commit into
dvacca-onfido wants to merge 1 commit into
Conversation
The helper previously returned an unset/null value after all retries failed, hiding the real API error. It now surfaces the last exception. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sofia-gomes-onfido
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test helper for retrying until the HTTP call succeeds (
repeat_request_until_http_code_changesor its equivalent) returned an unset/null value when every retry failed, hiding the real API error (e.g.UnboundLocalErrorin the Python tests). It now raises the last exception.