feature: Add test for clamping NotifyOnNReports#361
Open
weswaugh wants to merge 1 commit into
Open
Conversation
Resolves: VCV-15442 Signed-off-by: Waugh, Wesley <wesley.waugh@intel.com>
There was a problem hiding this comment.
Pull request overview
Adds a conformance test to validate that notifyEveryNReports is clamped (rather than failing or overflowing) when an extremely large value is requested for an IP, time-based metric streamer.
Changes:
- Added a new
zetMetricStreamerTestcase that opens a metric streamer withnotifyEveryNReports = UINT32_MAX. - Added assertions that the returned
notifyEveryNReportsvalue is clamped to a smaller, non-zero value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3056
to
+3057
| auto groupInfo = metricGroupInfo[0]; | ||
| lzt::activate_metric_groups(device, 1, &groupInfo.metricGroupHandle); |
Comment on lines
+3061
to
+3064
| auto streamer = lzt::metric_streamer_open_for_device( | ||
| device, groupInfo.metricGroupHandle, nullptr, requestedNotify, period); | ||
| ASSERT_NE(nullptr, streamer); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: VCV-15442