Repository navigation
fix(hub-ui): parse safe-area insets as pixel values - #2
Merged
Merged
Conversation
The computed insets are strings like "34px", so unary plus gave NaN and the dock always treated the insets as 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Folded into devframes#483. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the previous PR. The computed insets are strings like
"34px", so+valuewas always NaN and the dock treated every inset as 0.Number.parseFloatreads the pixel value.Checked in headless Chromium with the CDP safe-area override (top 47, bottom 34): the minimized dock moves up by exactly 34px; without the change it doesn't move.
🤖 Generated with Claude Code