Fix Application partial updates, enum case-insensitivity, and test execution - #1706
Open
prachi-okta wants to merge 1 commit into
Open
Fix Application partial updates, enum case-insensitivity, and test execution#1706prachi-okta wants to merge 1 commit into
prachi-okta wants to merge 1 commit into
Conversation
… execution (OKTA-1228269, OKTA-1232842, OKTA-1243191) - PartialApplicationUpdater: gives Application PUT true partial-update semantics by fetching the existing app, merging in only the caller's set fields, and replacing with the fully-populated result. Fixes 400s from omitting required sibling fields (name/credentials) on a partial OpenIdConnectApplication update. Rejects partial objects of a different concrete subtype than the existing application, rather than silently blending incompatible fields. Verified live against a real org in addition to unit tests. - useEnumCaseInsensitive=true (api/pom.xml): KnowledgeConstraint and PossessionConstraint enums are uppercase but the Policy API sends lowercase; fromValue() was case-sensitive and fell through to UNKNOWN_DEFAULT_OPEN_API. Fixes OKTA-1232842 and OKTA-1243191. - src/swagger/api.yaml: mark maxConsecutiveCharacters as EA, matching its sibling oelStatement - both are gated behind LIMITED_GA feature flags in okta-core, but only oelStatement disclosed that. - pom.xml: explicit surefire-testng provider dependency. Every test in the repo is TestNG, but api's junit-jupiter dependency made Surefire silently pick the JUnit Platform provider, running zero tests while reporting BUILD SUCCESS. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartialApplicationUpdater, a helper that givesApplicationPUT requests real partial-update semantics: it fetches the existing application, merges in only the fields set on the caller's partial object, and replaces with the fully-populated result. Fixes partial updates failing when required sibling fields (e.g.name,credentialsonOpenIdConnectApplication) are omitted.useEnumCaseInsensitive).KnowledgeConstraint/PossessionConstraintenums are uppercase, but the API sends lowercase values, sofromValue()was falling through toUNKNOWN_DEFAULT_OPEN_API.maxConsecutiveCharactersas EA in the spec, consistent with its siblingoelStatementfield.apimodule: an unusedjunit-jupiterdependency caused it to pick the JUnit Platform provider over TestNG, which every test in this repo actually uses.Test plan
PartialApplicationUpdatercovering partial updates that omitnameand/orcredentialsapiandimplmodules, all greenPartialApplicationUpdateradditionally verified against a live test orgAI Attribution:
ai-agent-authored