feat: add expert level — blind-by-design#74
Merged
Conversation
- Add optional metaDescription field to level schema, AdventureLevel type, generate script, and ChallengeDetail meta function - When present, metaDescription is used directly as the SEO meta description instead of the auto-generated formula from learnings, which was truncating mid-sentence with apostrophes encoding as ' - Add metaDescription to all three blind-by-design levels with purpose-built descriptions under 160 chars and no apostrophes - Add expert level (Read the Chart) to seo.test.ts, prerender.test.ts, and e2e/smoke.spec.ts - Delete stale test-b.generated.ts artifact - Improve new-adventure.mjs and new-level.mjs templates with clearer comments and examples - new-level.mjs now patches has_<level> flag in refresh-leaderboard.mjs automatically - WalkthroughSection renders all intro paragraphs, not just the first Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
- Replace conditional rendering with `hidden` attribute so `aria-controls` always references a DOM element, as required by the ARIA disclosure pattern - Add `focus-visible:ring-*` classes to the step button, matching the focus style used on all other interactive elements in the codebase - Change chevron rotation from `-rotate-90` (collapsed) to `rotate-180` (expanded), consistent with CollapsibleSection's `rotate-0`/`rotate-180` convention - Compress two-line `metaDescription` comment in types.ts to one line Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Level Added
blind-by-designexpertGenerated
src/data/adventures/blind-by-design/expert-posts.json(discussion stub)react-router.config.tspublic/sitemap.xmlManual step required
Paste this into the
levelsarray insrc/data/adventures/blind-by-design/adventure.yaml:Next steps
discussionUrlin the YAML and the-posts.jsonfilenode scripts/refresh-discussions.mjsnpm run lint && npm test && npm run build && npm run test:e2e