refactor(a11y): improve accessibility, clean up nav and challenges#73
Merged
Conversation
Key changes: - Add RouteAnnouncer in Layout.tsx so SPA navigations are announced to screen readers via a polite live region. - Upgrade Navbar mobile menu with focus trap (Tab wrapping, Escape to close, focus return to trigger), aria-hidden + inert on obscured content, and Challenges nav link now routes to /challenges instead of /#challenges. - Remove TechFilterSection, useActiveSection, and sonner (unused). Drop JetBrains Mono 500-weight font files (600 weight already served; 500 weight was a duplicate load). - Refactor ChallengesGrid: permanent sr-only aria-live region announces both filter-applied and filter-cleared states; add All pill; extract click handlers. - Refactor Challenges page: show all challenge levels by default (flat FilteredLevelCard grid) instead of AdventureCard grid; add All pill and permanent sr-only live region; fix URL construction to use BASE_URL; update page title to "Open Source Challenges". - RewardsCard: add deadlinePast prop; when deadline is past, replace eligibility text with a post-deadline message and Community Voices link (non-compact) or short pill note (compact). Move rewards card below leaderboard in this state. - Add isDeadlinePast utility in src/lib/utils.ts. - Add loader() exports to AdventureDetail and ChallengeDetail that compute rewardsBelowFold at build time. - ConsentBanner: switch aria-label to aria-labelledby on visible title paragraph; move initial focus to Decline button when banner appears. - MarkdownContent CodeBlock pre: add aria-label="Code block" so keyboard-focusable pre has an accessible name. - ChallengeDetail verification pre: add aria-label="Verification command". - Reduce firefly count from 12 to 8. - Add prefers-contrast and forced-colors media query blocks to index.css for OS-level accessibility. - Update Accessibility page, CLAUDE.md, styleguide.md, and smoke/unit/prerender tests to reflect all changes. Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
Contributor
|
- Expand ACCESSIBILITY.md into a full contributor checklist covering color contrast, focus rings, keyboard nav, touch targets, motion, semantic HTML, images, ARIA, forms, skip nav, and Windows High Contrast Mode; add WCAG principle reference table - Add PERFORMANCE.md with Lighthouse targets (95 target, current 93, floor 93), image, font, bundle, and motion guidance - Add Accessibility section to CLAUDE.md pointing to ACCESSIBILITY.md; remove duplicate ruleset - Remove nonexistent src/utils/ from CLAUDE.md repo layout; add missing workflow files and commands - Update docs-ext-link usage list in CLAUDE.md and styleguide.md (CommunitySidebar, RewardsCard, Accessibility, Privacy) - Update styleguide.md: remove useActiveSection docs, update LeaderboardRow shape (singlePoints), update Lighthouse scores table, fix RR version ref, update CommunityLeaders and buildPageMeta descriptions - Fix Accessibility.tsx contributor link to point to ACCESSIBILITY.md instead of CLAUDE.md - Update README.md shadcn/ui description to reflect minimal component surface Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes: