Skip to content

[IMP] rental: change to physical service product#18943

Closed
meval1006 wants to merge 1 commit into
saas-19.3from
saas-19.3-rental-update-service-products-meval
Closed

[IMP] rental: change to physical service product#18943
meval1006 wants to merge 1 commit into
saas-19.3from
saas-19.3-rental-update-service-products-meval

Conversation

@meval1006

Copy link
Copy Markdown
Contributor

What this PR does and why it's needed

Reworks the Rental app's service products documentation to distinguish between physical service products (e.g., hotel rooms, work stations) and non-physical (labor) service products, which now require different configuration steps. The rewrite adds a full walkthrough for setting up a physical service product synced with the Planning app, using a running hotel-room example throughout.

Changes

Service products (Rental)

  • Retitled service_products.rst to "Physical service rental products" and reframed the intro to explain that physical and labor (non-physical) services require different configurations
  • Added a new "Configure materials and a role for the physical product" section explaining how to set up a Planning role and materials so shifts sync with the physical product, illustrated with a hotel example (Shady Grove Deluxe Room)
  • Updated "Create a new service product" to require the Sales and Planning apps, set the Invoicing Policy to Prepaid/Fixed Price, and configure the product's Role page with the Sync Shifts and Rental Orders checkbox
  • Updated the base rental period/price section with descriptions for the Pickup and Return fields, in addition to Periodicity and Padding Time
  • Added a new "Set up variants" section showing how to configure product attributes (e.g., bed type, occupancy) for a physical service product
  • Simplified the pricelist creation guidance and clarified that the Prices tab requires the Pricelists feature to be enabled
  • Added a tip on adding a Validity date range column to pricelist rules
  • Added a new "eCommerce features" section describing how the eCommerce tab configures the product's website page
  • Added six new screenshots illustrating the Planning role/materials setup, the physical service product form, the Role page, and product variants

Rental product types

  • Added a rental/product_type/configuration anchor to product_type.rst so the Configuration section can be cross-referenced from the service products page

Rental orders

  • Updated create_rental_order.rst to note that smart-button app integration depends on the service product type, replacing the reference to the removed "properly configured" anchor

This saas-19.3 PR should not be FWP.

@meval1006 meval1006 self-assigned this Jul 15, 2026
@meval1006 meval1006 added the 2 label Jul 15, 2026
@robodoo

robodoo commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@meval1006
meval1006 force-pushed the saas-19.3-rental-update-service-products-meval branch from 6d22b8b to ce403cc Compare July 15, 2026 19:57
@meval1006
meval1006 requested a review from jero-odoo July 15, 2026 19:58
@meval1006
meval1006 marked this pull request as ready for review July 15, 2026 19:58
@meval1006

Copy link
Copy Markdown
Contributor Author

Hi @jero-odoo, this PR is ready to review. I am testing out the Skill.md file to summarize the PR.

@C3POdoo
C3POdoo requested a review from a team July 15, 2026 20:00

@jero-odoo jero-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @meval1006 ! Just a few notes

Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
@meval1006
meval1006 force-pushed the saas-19.3-rental-update-service-products-meval branch from 0e9770c to 7a1c4f3 Compare July 17, 2026 18:07
@meval1006
meval1006 requested a review from erjer-odoo July 17, 2026 18:08
@meval1006

Copy link
Copy Markdown
Contributor Author

Hi @erjer-odoo, this review is ready for final review.

@erjer-odoo erjer-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry there are so many comments; there were just some issues that I noticed while reviewing the file. As soon as you fix them, though, it should be good to go.

@robodoo delegate+

Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Comment thread content/applications/sales/rental/configure_products/service_products.rst Outdated
Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>

Co-authored-by: Erin J <erjer@odoo.com>
@meval1006
meval1006 force-pushed the saas-19.3-rental-update-service-products-meval branch from 25c9e80 to e7fc90e Compare July 21, 2026 23:51
@meval1006

Copy link
Copy Markdown
Contributor Author

@robodoo FW=no

@robodoo

robodoo commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

@meval1006 unknown command 'FW'.

For your own safety I've ignored everything in your entire comment.

Currently available commands:

command
help displays this help
r(eview)+ approves the PR, if it's a forwardport also approves all non-detached parents
r(eview)=<number> only approves the specified parents
r(eview)- removes approval of a previously approved PR, if the PR is staged the staging will be cancelled
retry re-tries staging a PR in the "error" state
fw=no does not forward-port this PR
fw=default forward-ports this PR normally
fw=skipci does not wait for a forward-port's statuses to succeed before creating the next one
fw=skipmerge does not wait for the source to be merged before creating forward ports
up to <branch> only ports this PR forward to the specified branch (included)
merge integrate the PR with a simple merge commit, using the PR description as message
rebase-merge rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
rebase-ff rebases the PR on top of the target branch, then fast-forwards
squash squashes the PR as a single commit on the target branch, using the PR description as message
delegate+ grants approval rights to the PR author
delegate=<...> grants approval rights on this PR to the specified github users
check fetches or refreshes PR metadata, resets mergebot state
remindme:<branch>=<message> When the PR gets forward-ported to <branch>, ping you with <message>. <message> can be quoted if it needs spaces.

Note: this help text is dynamic and will change with the state of the PR.

@meval1006

Copy link
Copy Markdown
Contributor Author

@robodoo fw=no

@robodoo

robodoo commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Disabled forward-porting.

@meval1006

Copy link
Copy Markdown
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Jul 22, 2026
closes #18943

Signed-off-by: Megan Valenzuela (meval) <meval@odoo.com>
Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
Co-authored-by: Erin J <erjer@odoo.com>
@robodoo robodoo closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants