[IMP] rental: change to physical service product#18943
Closed
meval1006 wants to merge 1 commit into
Closed
Conversation
Collaborator
meval1006
force-pushed
the
saas-19.3-rental-update-service-products-meval
branch
from
July 15, 2026 19:57
6d22b8b to
ce403cc
Compare
meval1006
marked this pull request as ready for review
July 15, 2026 19:58
Contributor
Author
|
Hi @jero-odoo, this PR is ready to review. I am testing out the Skill.md file to summarize the PR. |
jero-odoo
approved these changes
Jul 17, 2026
jero-odoo
left a comment
Contributor
There was a problem hiding this comment.
Nice work @meval1006 ! Just a few notes
meval1006
force-pushed
the
saas-19.3-rental-update-service-products-meval
branch
from
July 17, 2026 18:07
0e9770c to
7a1c4f3
Compare
Contributor
Author
|
Hi @erjer-odoo, this review is ready for final review. |
erjer-odoo
approved these changes
Jul 17, 2026
erjer-odoo
left a comment
Contributor
There was a problem hiding this comment.
Sorry there are so many comments; there were just some issues that I noticed while reviewing the file. As soon as you fix them, though, it should be good to go.
@robodoo delegate+
Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com> Co-authored-by: Erin J <erjer@odoo.com>
meval1006
force-pushed
the
saas-19.3-rental-update-service-products-meval
branch
from
July 21, 2026 23:51
25c9e80 to
e7fc90e
Compare
Contributor
Author
|
@robodoo FW=no |
Collaborator
|
@meval1006 unknown command 'FW'. For your own safety I've ignored everything in your entire comment. Currently available commands:
Note: this help text is dynamic and will change with the state of the PR. |
Contributor
Author
|
@robodoo fw=no |
Collaborator
|
Disabled forward-porting. |
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jul 22, 2026
closes #18943 Signed-off-by: Megan Valenzuela (meval) <meval@odoo.com> Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com> Co-authored-by: Erin J <erjer@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does and why it's needed
Reworks the Rental app's service products documentation to distinguish between physical service products (e.g., hotel rooms, work stations) and non-physical (labor) service products, which now require different configuration steps. The rewrite adds a full walkthrough for setting up a physical service product synced with the Planning app, using a running hotel-room example throughout.
Changes
Service products (Rental)
service_products.rstto "Physical service rental products" and reframed the intro to explain that physical and labor (non-physical) services require different configurationsRental product types
rental/product_type/configurationanchor toproduct_type.rstso the Configuration section can be cross-referenced from the service products pageRental orders
create_rental_order.rstto note that smart-button app integration depends on the service product type, replacing the reference to the removed "properly configured" anchorThis
saas-19.3PR should not be FWP.