[IMP] Events: Update Sell event tickets page 18.0#16643
[IMP] Events: Update Sell event tickets page 18.0#16643stepperpig wants to merge 1 commit into18.0from
Conversation
|
|
|
@Felicious ready for your review! |
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Great work on your first PR @stepperpig !!
I made some super minor suggestions on style. Some required changes are making sure the images don't contain the red markup and removing the align centers.
Since this is your first PR, I'd like @nikibrown to review to make sure all my feedback was implemented properly and that there aren't unaddressed make review errors! He will help you merge when that review's done (: Just to clarify that niki's review is just this time!
stepperpig
force-pushed
the
18.0-events-update-sell-tickets-page-kaili
branch
from
fb60ef5 to
8f714dd
Compare
|
Hi @nikibrown, tagging you for a review to make sure nothing breaks and to help merge this! :) |
nikibrown
left a comment
nikibrown
left a comment
There was a problem hiding this comment.
@stepperpig if you run make review on sell_tickets.rst you will see a bunch of early-line-break warnings. Super easy fix, squash and then push up to this PR again.
Co-authored-by: Felicia Kuan <feku@odoo.com>
stepperpig
force-pushed
the
18.0-events-update-sell-tickets-page-kaili
branch
from
be155c1 to
c3475e6
Compare
|
thanks for the review, @nikibrown! is there anything else i need to do to merge this PR? |
|
@robodoo delegate+ |
|
@robodoo r+ |
closes #16643 Signed-off-by: Kai Wen Li (kaili) <kaili@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com>
4 participants
Goal
Update the 'Sell event tickets' page to 18.0, adding additional sections/information not included in previous 17.0 version.
Changelog
Version Scope
This should be FWP up to master. Any changes relevant to 19.0 will be made in separate PR after merge.