Repository navigation
ci: sign again when Apple's timestamp service refuses a macOS signature - #391
Merged
Merged
Conversation
codesign and productbuild ask Apple's timestamp service for every signature, and one refusal ended the release. Each of the three signing calls is now tried up to five times, a minute apart, when the tool's last line is that refusal. Any other failure returns the tool's status at once, and the timestamp stays required. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The macOS installer build asks Apple's timestamp service for every signature. One refusal ended the v1.33.0 release run at
Installers / macOS installerswithThe timestamp service is not available., and the release had to be re-run.installers/macos/build.shnow tries each of its three timestamped signing calls (twocodesign, oneproductbuild) up to five times, a minute apart, when the tool's last stderr line is a timestamp refusal.--timestampis on every attempt; there is no fallback.Tests
tests/installers.test.mjsruns the realbuild.shagainst stand-in tools, withsleeplogged instead of waited:Not covered
Real
codesign,productbuildand notarization run only in therelease-signingenvironment, which allowsmainonly. The wrapper first runs against Apple's tools in the next release; publishing depends on the installers, so a failure there publishes nothing.🤖 Generated with Claude Code