Skip to content

ci: sign again when Apple's timestamp service refuses a macOS signature - #391

Merged
oddessentials merged 1 commit into
mainfrom
fix/macos-timestamp-retry
Nov 12, 2026
Merged

oddessentials merged 1 commit into
mainfrom
fix/macos-timestamp-retry

Conversation

@oddessentials

Copy link
Copy Markdown
Owner

What

The macOS installer build asks Apple's timestamp service for every signature. One refusal ended the v1.33.0 release run at Installers / macOS installers with The timestamp service is not available., and the release had to be re-run.

installers/macos/build.sh now tries each of its three timestamped signing calls (two codesign, one productbuild) up to five times, a minute apart, when the tool's last stderr line is a timestamp refusal.

  • Any other failure returns the tool's own status at once.
  • When every try is refused, the build fails with the last try's status.
  • --timestamp is on every attempt; there is no fallback.

Tests

tests/installers.test.mjs runs the real build.sh against stand-in tools, with sleep logged instead of waited:

  • a refusal followed by success, at all three calls
  • five refusals, failing with the last status
  • other failures, including ones that mention the timestamp service, failing after one call

Not covered

Real codesign, productbuild and notarization run only in the release-signing environment, which allows main only. The wrapper first runs against Apple's tools in the next release; publishing depends on the installers, so a failure there publishes nothing.

🤖 Generated with Claude Code

codesign and productbuild ask Apple's timestamp service for every signature,
and one refusal ended the release. Each of the three signing calls is now
tried up to five times, a minute apart, when the tool's last line is that
refusal. Any other failure returns the tool's status at once, and the
timestamp stays required.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@oddessentials
oddessentials merged commit fba42f1 into main Nov 12, 2026
35 checks passed
@oddessentials
oddessentials deleted the fix/macos-timestamp-retry branch November 12, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant