Repository navigation
test: judge only systemd warnings about the unit under test - #390
Closed
oddessentials wants to merge 1 commit into
Closed
oddessentials wants to merge 1 commit into
oddessentials wants to merge 1 commit into
Conversation
systemd-analyze verify also loads the machine's own units and prints their warnings. The Ubuntu 26.04 runner image ships units that set the removed CPUAccounting= option, so the check for an empty stderr failed there. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Owner
Author
|
Folded into #389 so the fix and the feature are one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test
systemd reads the unit as writtenrequiredsystemd-analyze verifyto print nothing on stderr. Verifying a unit also loads the machine's own units and prints their warnings. The Ubuntu 26.04 runner image, whichubuntu-latestis moving to, ships units that set the removedCPUAccounting=option, so the test failed there with warnings such as:The test now leaves out only warnings that name another unit's file. Warnings about the unit under test, any other stderr output, any stdout and a non-zero exit still fail it. A new test pins that filtering.
Testing
tests/systemd-service.test.mjspasses on Windows, where the systemd test itself is skipped.🤖 Generated with Claude Code