Skip to content

add db username and pass #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bogdanfazakas merged 3 commits into from
Jan 26, 2026
Merged

add db username and pass #418

bogdanfazakas merged 3 commits into from
Jan 26, 2026

Conversation

@bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Jan 20, 2026 •
edited
Loading

  • add username and pass env for node
  • test defensive null checks
  • fixes this issue in ocean.js with databases
  • once the pr-1156 is merged we can revert the changes related to the image of ocean-node and merge this

@bogdanfazakas bogdanfazakas marked this pull request as ready for review January 20, 2026 09:34
@alexcos20
Copy link
Member

alexcos20 commented Jan 22, 2026

@bogdanfazakas - I defined some envs in start_ocean and used them across the stack

@alexcos20 alexcos20 requested a review from andreip136 January 22, 2026 12:15
@bogdanfazakas bogdanfazakas merged commit 2e71464 into main Jan 26, 2026
@bogdanfazakas bogdanfazakas deleted the test-node-pr1156 branch January 26, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndrpp ndrpp ndrpp approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@giurgiur99 giurgiur99 Awaiting requested review from giurgiur99 giurgiur99 is a code owner

@denisiuriet denisiuriet Awaiting requested review from denisiuriet denisiuriet is a code owner

@andreip136 andreip136 Awaiting requested review from andreip136 andreip136 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bogdanfazakas @alexcos20 @ndrpp @andreip136