fix: restore worktree handoff in brainstorming after spec approval#1097
Open
pejmanjohn wants to merge 1 commit intoobra:mainfrom
Open
fix: restore worktree handoff in brainstorming after spec approval#1097pejmanjohn wants to merge 1 commit intoobra:mainfrom
pejmanjohn wants to merge 1 commit intoobra:mainfrom
Conversation
2 tasks
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Fixes #1080.
After the user approves the written spec, the
brainstormingskill currently tells Claude to invokewriting-plansimmediately, skippingusing-git-worktrees. That leaves the checklist and process flow inconsistent with the documented worktree-first handoff, and it contradictswriting-plans, which expects to run in a dedicated worktree created by brainstorming.In a Claude Code eval against the unchanged plugin directory, asking what happens after the user approves the written spec produced: “invoke the
writing-plansskill to create a detailed implementation plan.” That is the specific failure mode this PR fixes.What does this PR change?
This PR updates
skills/brainstorming/SKILL.mdso the checklist, process flow, terminal-state guidance, user review gate text, and implementation handoff all consistently route:brainstorming→using-git-worktrees→writing-plansIs this change appropriate for the core library?
Yes. This is a general-purpose workflow fix in a core skill that affects any user following the documented brainstorming-to-implementation path. It is not project-specific, team-specific, or tied to a third-party integration.
What alternatives did you consider?
I considered a checklist-only fix, but rejected it because it would leave the flowchart, terminal-state guidance, and user review gate wording internally contradictory. I also considered editing
using-git-worktreesorwriting-plans, but those files already describe the intended handoff; the inconsistency was localized tobrainstorming, so I kept the change to that file.Does this PR contain multiple unrelated changes?
No. This PR only fixes the
brainstormingskill’s handoff after spec approval so it matches the documented worktree-first workflow.Existing PRs
Environment tested
claude-opus-4-6Evaluation
Lets look at https://github.com/obra/superpowers and see if there are any good PR opportunitiesyes lets target #1080-psessions against the modified plugin directorywriting-plansdirectly.using-git-worktreesfirst.using-git-worktreesfollowed bywriting-plans.using-git-worktreesmust happen first and that the handoff cannot be skipped.Rigor
superpowers:writing-skillsand completed adversarial pressure testing (paste results below)Adversarial result used for this PR:
using-git-worktreesmust be invoked first, followed immediately bywriting-plans, and said these steps cannot be skipped.Human review