Cleanup: remove orphaned *.state.ts files and dangling 'admin' seed refs#16
Merged
Merged
Conversation
Follow-up cleanup after the 7.7.0 migration (#15). - Delete the 14 `*.state.ts` files. After lifecycle machines moved from the unsupported object-level `stateMachines` key into `state_machine` validation rules, nothing imports these modules; leaving them is misleading (they look authoritative but are dead). - Remove 10 dangling `assignee: 'admin'` / `author_user: 'admin'` refs from the helpdesk seed. Templates seed no `sys_user`, so 'admin' matches nothing and resolved to null; dropping keeps the seed honest (tickets/messages load unassigned). Both fields are optional. 9/9 build green, typecheck clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup after the 7.7.0 migration (#15).
*.state.tsfiles. After lifecycle machines moved from the unsupported object-levelstateMachineskey intostate_machinevalidation rules, nothing imports these modules. Leaving them is misleading — they look authoritative but are dead.assignee: 'admin'/author_user: 'admin'refs from the helpdesk seed. Templates seed nosys_user, so'admin'matches nothing and resolved tonull; dropping keeps the seed honest (tickets/messages load unassigned). Both fields are optional.9/9 packages build green, typecheck clean.
🤖 Generated with Claude Code