fix(app-shell): the Studio grid's columns keep a stable identity — no duplicate find() per render (#4567)

[yinlianghui]

Fixes #4567

The chain — all three legs verified on origin/main at ffca56f

1. Producer — StudioDesignSurface built the object-view table.fields with readFields(objDraft.fields).entries.map(...).filter(...) inline, allocating a fresh array on every render of the pillar.
2. Forward — plugin-view's ObjectView hands that array to the renderListView slot as columns by reference (packages/plugin-view/src/ObjectView.tsx:997 — no map/filter of its own). In design mode there is no saved view, so it falls through to schema.table?.fields.
3. Consumer — ListView derives expandFields from schema.columns with that array in the memo's dependency array by identity (packages/plugin-list/src/ListView.tsx:1245-1294), and expandFields is itself in the fetch effect's dependency array (:1609). A fresh array therefore refetches.

The fix — producer side

The columns array is memoized on the draft's fields, so it changes identity only when its contents change. ListView's by-identity dependency is untouched — it is correct for a genuine column change, and plugin-list is read-only for this card.

Memo inputs, measured rather than guessed

• objDraft is React.useState (StudioDesignSurface.tsx:2002), so it is stable across renders and a sound key.
• The correct key is objDraft.fields, not objDraft: onPatch does a spread that replaces the draft object while keeping fields identical, so the looser key would churn the columns — and refetch — on every unrelated draft edit such as an icon or label change. The neighbouring fieldCount memo uses the looser key; this one deliberately takes the tighter one.
• STUDIO_SYSTEM_FIELD_NAMES is a module-scope Set, so it is stable and not a dependency.
• No other fetch-dep churn exists on this path: renderStudioGridList adds only primitives plus addRecord, which is not in ListView's fetch dependency array, and schema.data / schema.filter / schema.searchableFields are all undefined here. expandFields was the only per-render identity churn, which is why the producer memo alone reaches exactly zero — matching the filer's hoisted-columns measurement.

Red-first, with the filer's measurement shape

New suite StudioDesignSurface.gridColumns.test.tsx drives the real producer (DataPillar), not a reconstruction — the defect is a property of how that component builds its schema, so a harness building its own array would measure the harness.

Predicted before running: three no-op re-renders grow the find() count by exactly 3. Actual, verbatim, before the fix:

AssertionError: expected 5 to be 2 // Object.is equality
- Expected  2
+ Received  5

Exactly +3, one per render, reproducing the filer's 1 to 4 shape (this harness's mount settles at 2 rather than 1; the delta is the measurement). After the fix: 2 tests passed.

Reverse verification

Fix removed via a patch file plus git checkout -- (never git stash), restore sha256-verified:

• no-op re-render case: red again, expected 5 to be 2
• real-column-change case: stays green

Must-not-change pins

• The dependency stays live. A real column change still refetches. That pin is green before and after the fix by design — it is a must-not-change, not a red-first case, and reporting it as red would be a fabrication. Its force comes from the path it uses: "+ Add field" mutates objDraft.fields without remounting the grid (its key is unchanged), so the refetch it produces can only have arrived through the column-identity dependency chain. A memo that froze the columns or returned a constant turns it red.
• Studio Data pillar ignores its renderListView slot's refreshKey — the prop was forwarded to a component that never declared it #4549 / PR chore(app-shell): the dead slot refreshKey parameter is removed (#4549) #4571 untouched. Its gridRefresh suite stays exactly as it is, including its own STABLE_COLUMNS hoisting — that workaround is what this fix makes unnecessary in production, but removing it from that suite would change what those tests measure. Both its bump-refetch and no-storm cases stay green.
• fix(app-shell): the default-inspector family and its panel hosts gate Save on CEL errors (#4527) #4558 panel/inspector wiring untouched; the renderStudioGridList region is not disturbed beyond the memo.

Verification

• vitest run --maxWorkers=2 packages/app-shell/src/views/studio-design/ — 26 files, 146 tests passed
• pnpm --filter @object-ui/app-shell type-check — both tsc passes green (tsc --noEmit and tsc -p tsconfig.test.json)
• ESLint net zero vs origin/main: the touched source file reports 15 warnings / 0 errors both before and after; the new test file contributes 0
• check:control-bytes, check:phantom-deps green; control-character self-scan over every touched file clean
• Public entry .d.ts byte-identical both ways — dist/ and tsconfig.tsbuildinfo cleared between builds, same sha256 72075d2c..., empty diff. Module-local memoization, hence patch.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 13, 2026 12:05pm

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	index-B-FSdT22.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	25.13KB	5.40KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	38.46KB	10.17KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	489.32KB	108.45KB
core (index.js)	3.37KB	1.34KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	163.56KB	44.83KB
fields (index.js)	230.37KB	57.17KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.84KB	1.45KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.86KB	12.91KB
plugin-charts (index.js)	62.10KB	17.67KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	120.99KB	31.55KB
plugin-designer (index.js)	212.58KB	42.83KB
plugin-detail (index.js)	239.88KB	59.99KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	164.30KB	40.02KB
plugin-grid (index.js)	189.37KB	50.33KB
plugin-kanban (index.js)	52.74KB	14.53KB
plugin-list (index.js)	111.13KB	27.12KB
plugin-map (index.js)	18.16KB	5.81KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	41.16KB	10.96KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.08KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.73KB	7.96KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[yinlianghui]

PM step-7 复核 — ACCEPT (session_017Qqyix2QcnpUC9XeYVDzx3)

• The memo key is the review's centerpiece: objDraft.fields, not objDraft — measured against onPatch's spread (fields identity survives unrelated draft edits, so the looser key would refetch on an icon rename), and the neighbouring fieldCount memo's looser key deliberately NOT copied. That is identity-stabilization done at the right grain.
• The three-leg verification makes the fix trustworthy: producer forwards BY REFERENCE (had ObjectView re-derived the array the memo would have been useless — checked BEFORE writing it), consumer depends by identity, and the completeness enumeration proves expandFields was the only per-render churn, which is why the single memo reaches exactly zero.
• Red-first judged on the DELTA (+3, one find per no-op render) with the harness's 2-vs-1 baseline declared rather than tuned. The real-column-change pin is reported honestly as green-both-ways liveness — and its construction (Add field without remounting, so the refetch can only arrive through the identity chain) makes it a genuine guard a frozen memo turns red.
• The new-file deviation is right: module-level mocks folded into chore(app-shell): the dead slot refreshKey parameter is removed (#4549) #4571's suite would have changed the environment its tests run in, which the ruling forbade; a separate file leaves it byte-untouched, including its now-redundant-in-production STABLE_COLUMNS hoisting whose removal would change what those tests measure.
• dts byte-identical → patch; NET ZERO lint; TaskStop by ID never name; the pnpm --filter <pkg> test -- --run <paths> 静默忽略路径过滤:新加的测试文件根本没跑,而输出看起来正常 #3288 vitest-guard trip corrected; CI 20/20 per-job. Finding Studio Data pillar form designer rebuilds ObjectForm's fields array every render — redundant field-list recomputation (no duplicate query) #4574 (the ObjectForm sibling — recomputation only, effect body READ before filing to prove no duplicate query) filed properly as observation-class.

Auto-merge armed (squash) — landing verified per the merge-queue discipline.

---

Generated by Claude Code

---

Generated by Claude Code