fix(types): the DataSource contract carries deleteView's per-home outcomes (#4564)

[yinlianghui]

Fixes #4564

PR #4562 (#4479) widened the ObjectStack adapter's deleteView to return DeleteViewResult { deleted, draft?, published? }. The shared interface did not follow: DataSource.deleteView? still declared the narrow Promise< { deleted: boolean } >.

Nothing failed to compile, and that is precisely what made the gap invisible — a wider return is assignable to a narrower declaration, so the adapter satisfied the interface while every consumer reaching it through DataSource was handed a type with the per-home outcomes already discarded. Today's single real call site (app-shell's ObjectView delete handler) awaits the call and reads nothing off the receipt, so the loss was latent rather than broken.

Implements the PM ruling on the card (option a).

What changed

• ViewHomeDeleteOutcome and DeleteViewResult now live in packages/types/src/data.ts, beside the DataSource interface that returns them.
• DataSource.deleteView?'s declared return widens to Promise< DeleteViewResult >. Still optional, same two parameters — the growth is to the return type only, and deleted is untouched.
• packages/data-objectstack/src/index.ts imports both names for its own use and re-exports them under the same names. Zero behavior lines: deleteView's implementation, readViewDeleteReceipt, and metadata-client.ts are untouched.
• packages/types/src/index.ts adds both names to the ./data export block — required for entry-reachability, and the basis of the types minor grading.

The direction was forced. The dependency runs @object-ui/data-objectstack to @object-ui/types and never the other way, so the shapes could not be imported downward. Moving them was the alternative to re-declaring a structural twin in types — which the one-resolver rule rejects, because a copy stays mutually assignable with the original for exactly as long as it takes to drift.

Importer census, measured before the move

Repo-wide grep for both spellings on origin/main at 537a0d19c: zero importers outside the declaring file itself — PR #4562's own deleteView.homes.test.ts included, which types its adapter as any and never names either type. The re-export is therefore insurance for future importers, not a load-bearing shim. The only DataSource.deleteView call site repo-wide is packages/app-shell/src/views/ObjectView.tsx:1237-1238, which reaches it through (dataSource as any) and reads nothing; it is unedited and compiles unchanged.

Red first

The new pins were written and run before the fix. pnpm --filter @object-ui/data-objectstack type-check on unmodified main returned 14 diagnostics, headlined by the issue's own sentence:

src/deleteViewContract.types.test.ts(10,27): error TS2305: Module '"@object-ui/types"' has no exported member 'DeleteViewResult'.
src/deleteViewContract.types.test.ts(10,45): error TS2305: Module '"@object-ui/types"' has no exported member 'ViewHomeDeleteOutcome'.
src/deleteViewContract.types.test.ts(168,59): error TS2339: Property 'draft' does not exist on type '{ deleted: boolean; }'.
src/deleteViewContract.types.test.ts(170,28): error TS2339: Property 'published' does not exist on type '{ deleted: boolean; }'.
src/deleteViewContract.types.test.ts(242,20): error TS2339: Property 'draft' does not exist on type '{ deleted: boolean; }'.
src/deleteViewContract.types.test.ts(243,20): error TS2339: Property 'published' does not exist on type '{ deleted: boolean; }'.
src/deleteViewContract.types.test.ts(244,20): error TS2339: Property 'draft' does not exist on type '{ deleted: boolean; }'.

plus seven TS2344: Type 'false' does not satisfy the constraint 'true' on the identity assertions. All 14 are green after the change.

Reverse verification. The three source files were taken back out with git diff + git checkout -- (never git stash), @object-ui/types was rebuilt so the check read the reverted declarations rather than a fresh dist, and the same 14 diagnostics returned byte-identically. Restored via git apply, sha256sum -c OK on all three.

Two honest notes on where the pins get their colour

Both are stated in the test file's header rather than left for a later reader.

1. The pins are compile-time because the defect is. vitest transpiles with esbuild and erases types. Measured: with the fix reverted, the new file is 7/7 green under vitest while tsc returns 14 errors. The colour comes from type-check, which this package's tsconfig.json applies to its whole src/**, tests included.

2. A satisfies / extends assertion does not discriminate here, and I did not pretend otherwise. The card asked for an explicit satisfies-style assertion, and it is present — but measured on unmodified main, both adapter.deleteView satisfies ContractDeleteView and the extends form are green in both worlds, for exactly the assignability reason the gap exploited. Only the type identity assertions (Equal< ... >) go red. The file carries both and says which one is load-bearing.

A live NarrowLegacyResult control models the pre-#4564 declaration, so "the contract used to lose the per-home outcomes" stays an assertion the compiler re-checks rather than a comment.

Must-not-change, verified

• PR fix(data-objectstack): deleteView removes every home the view has — draft-only, published, and pairs (#4479) #4562's deleteView.homes.test.ts — untouched, all 15 pins green.
• viewCacheInvalidation.pin.test.ts — green, untouched.
• deleteView? still optional, same two parameters, deleted still boolean — pinned.
• ObjectView.tsx and metadata-client.ts — not edited; app-shell type-checks green.

Emitted .d.ts, measured both ways

Clean dist/ and tsconfig.tsbuildinfo between builds.

• @object-ui/types — additive: two new exported interfaces, the widened return, the entry re-export. minor (entry-reachable growth).
• @object-ui/data-objectstack — not byte-identical, so this is the ruling's "declaration moved" branch: the two interface blocks leave dist/index.d.ts and become a re-export from @object-ui/types (121.61 KB to 120.25 KB). Both names remain in the public export list, so no importer breaks, but the declaration genuinely relocated and the emitted types now depend on @object-ui/types for it. minor, not patch.

Neither is major, per the repository's version-alignment convention (the major tracks @objectstack, never an API-break count).

Verification

All heavy steps serialized on the shared flock with a capped heap.

• Dependency-closure build first, then pnpm --filter "@object-ui/types" --filter "@object-ui/data-objectstack" type-check — both Done.
• pnpm exec vitest run --maxWorkers=2 packages/data-objectstack/ packages/types/ — 66 files, 895 tests passed (baseline before the change: 65 / 888).
• Downstream consumer sweep, prefix filter pnpm --filter "...@object-ui/types" type-check — the consumer direction, not the dependency one — 42 of 47 workspace projects, 0 errors. Full workspace build (43/43) run first, because the sweep initially hit a genuine TS2307 stale-artifact error in @object-ui/collaboration.
• eslint on both packages: 0 errors. The new file adds no-unused-vars warnings on its type aliases; that is the repo's existing type-pin idiom, which already emits 29 of them in queryDataset.test.ts on main.
• check:control-bytes OK (4315 tracked files), check:phantom-deps OK, changeset:check OK. Self-scan with grep -naP over every touched file: clean.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 13, 2026 10:46am

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	index-DGGIWhJL.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	25.13KB	5.40KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	38.46KB	10.17KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	489.32KB	108.45KB
core (index.js)	3.37KB	1.34KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	163.56KB	44.83KB
fields (index.js)	230.18KB	57.13KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.84KB	1.45KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.86KB	12.91KB
plugin-charts (index.js)	62.10KB	17.67KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	120.95KB	31.53KB
plugin-designer (index.js)	212.58KB	42.83KB
plugin-detail (index.js)	239.88KB	59.99KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	164.28KB	40.02KB
plugin-grid (index.js)	189.36KB	50.33KB
plugin-kanban (index.js)	52.74KB	14.53KB
plugin-list (index.js)	111.13KB	27.12KB
plugin-map (index.js)	18.16KB	5.81KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	41.16KB	10.96KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.08KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.73KB	7.96KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[yinlianghui]

PM step-7 复核 — ACCEPT (session_017Qqyix2QcnpUC9XeYVDzx3)

• The census came back stronger than the ruling predicted (zero importers anywhere — even fix(data-objectstack): deleteView removes every home the view has — draft-only, published, and pairs (#4479) #4562's own test types its adapter as any), with the stale-tree first grep caught and redone inside the worktree before any conclusion was drawn.
• The red-first is compile-time because the DEFECT is: 14 verbatim diagnostics on unmodified main, the TS2339 pair being the issue's own sentence stated by the compiler, and the reverse verification REBUILT @object-ui/types so tsc read the reverted declarations rather than a fresh dist. The vitest-erasure trap (fix reverted ⇒ 7/7 green under vitest, 14 errors under tsc) is documented in the file header with a live NarrowLegacyResult control re-checking the discrimination every run instead of asserting it in prose.
• The honest finding against the ruling's own pin Implement visual designer for Object UI schemas #1 is exactly what review is for: satisfies/extends is GREEN in both worlds here — a wider return is assignable to a narrower declaration, which is precisely how the gap survived PR fix(data-objectstack): deleteView removes every home the view has — draft-only, published, and pairs (#4479) #4562 — so only the Equal-identity assertions are load-bearing, and the file says so. Ruling intent served, prescribed form measured vacuous and corrected.
• dts measured to the ruling's branch: types additive; data-objectstack's declaration genuinely relocated (interfaces → re-export line) ⇒ MINOR, not patch. The one-line types/src/index.ts surface extension is declared and was presupposed by the grading itself.
• 42/47 consumer sweep green after the full workspace build cleared the stale-artifact TS2307; fix(data-objectstack): deleteView removes every home the view has — draft-only, published, and pairs (#4479) #4562's 15 pins + the cache-invalidation pins untouched and green by name; CI 20/20 on per-job conclusions.

Auto-merge armed (squash) — landing verified per the merge-queue discipline.

---

Generated by Claude Code

---

Generated by Claude Code