fix(plugin-grid): the record-detail date fallback threads the display locale (#4541)

[yinlianghui]

Fixes #4541

ObjectGrid's renderRecordDetail → renderFieldValue is type-aware first: when the object schema gives a key a type with a registered cell renderer, that renderer draws the value. Everything else falls through to an inference fallback, whose date branch called formatDate(value) with no options at all. formatDate then handed Intl an undefined tag, and undefined is not "the user's locale" — it is the machine's, which is neither of the repo's two locale channels. On a zh console this one cell rendered Mar 15, 2024 while every neighbouring date cell rendered 2024年3月15日.

This was the third formatDate site in the file. #4272 (PR #4544) ruled its plugin-grid surface to "ONLY the two date-cell call sites" — the two that pass 'short' in the mobile card view, which shift by a constant −121 line offset — and this site does not fit that mapping, so #4544 filed it here rather than fixing it.

The change

Pure consumption, not plumbing, exactly as the ruling sized it. The component already reads useDisplayLocale() at component level (landed in PR #4544 for the two 'short' cells), and renderRecordDetail is a plain arrow declared in the component body — it already closes over tenantCurrency from that same scope two branches below. Measured before implementing: the closure sees the hook value, so nothing needed lifting.

file	site
packages/plugin-grid/src/ObjectGrid.tsx	renderRecordDetail's date-inference fallback — one call gains { locale: displayLocale }

No hook was added, and the function is not memoized, so there is no dependency array to keep in step. One resolver everywhere, unchanged: useDisplayLocale() (tenant regional default → active UI language → 'en').

Red-first, and honest direction labelling

Predicted in writing before running anything, then run against unfixed code: 2 red, 1 green-both-sides. Actual matched per case.

Measured on the runner (node v22.22.2, TZ=UTC, machine locale en-US) for formatDate's default branch:

value	machine / undefined	en	zh	de
2024-03-15T12:00:00	Mar 15, 2024	Mar 15, 2024	2024年3月15日	15. März 2024
2024-07-04T09:30:00	Jul 4, 2024	Jul 4, 2024	2024年7月4日	4. Juli 2024

en and the machine's en-US are identical here, so the en case is a PIN — the byte-identical must-not-change half — and not red evidence that the fix works. It is labelled that way in the file rather than presented as proof. Every expectation spells 'en' / 'zh' / 'de' explicitly; none is computed from a bare toLocale* call against the runner (the #4513 trap).

The genuine reds, verbatim:

AssertionError: expected 'NameAliceClose dateMar 15, 2024Signed…' to contain '2024年3月15日'
  Received: "NameAliceClose dateMar 15, 2024Signed atJul 4, 2024"
AssertionError: expected 'NameAliceClose dateMar 15, 2024Signed…' to contain '15. März 2024'
  Received: "NameAliceClose dateMar 15, 2024Signed atJul 4, 2024"

The tenant-over-UI-language precedence case uses de deliberately: 15. März 2024 matches neither the machine's Mar 15, 2024 nor zh's 2024年3月15日, so it is genuinely red before the fix instead of passing by coincidence.

Reverse verification took the fix out with a patch file plus git checkout (never git stash), re-ran, got exactly the same 2 reds, and restored with a sha256-verified match on ObjectGrid.tsx.

Reaching the branch at all — the #4544 naming lesson, restated

PR #4544's grid suite had to name its columns like dates because the card view's classify() routes by dateKeys substrings. The record-detail path has the same shape of trap in a different place, and both halves matter:

1. The fixture passes data: { provider: 'value', items: ROWS } and no dataSource, so objectSchema stays null and the field descriptor is undefined for every key. That is what skips the cell-renderer branch and drives the value into the inference fallback where this bug lives. Give the field a schema type: 'date' instead and DateCellRenderer draws it — a different, already-fixed path — and the suite would pin nothing.
2. The keys must be named like dates. close_date (matches date) and signed_at (matches _at) cover two of the branch's three spellings; a key such as closed_on would fall past the branch to the plain String() tail and render no date at all.

Both fixture keys are deliberately non-system, and neither is a grid column, so the value reaches the DOM only through the detail panel. Assertions read getByTestId('record-detail-panel').textContent rather than the container: the overlay is portaled, and a container-wide toContain could otherwise be satisfied by an ordinary grid cell rendering the same date through the already-localized renderer — passing for the wrong reason.

Verification

• Full packages/plugin-grid suite: 64 files, 595 tests, all passing — including fix(fields): the date formatter's last three en-US channels thread the display locale (#4272) #4544's mobileCardDateLocale.test.tsx, the fix(plugin-grid): the link column renders a real anchor when the host publishes record URLs (#4490) #4531 ObjectGrid.linkCellAnchor pins and rowCrudAffordances.
• type-check green (both tsc --noEmit and tsconfig.test.json).
• ESLint measured against the origin/main baseline: identical — ObjectGrid.tsx 244 problems (0 errors, 244 warnings) both ways; the new test file adds 0. No new findings.
• check:control-bytes green, re-run after staging so the two new files were actually in the tracked scan (4274 → 4276 files); plus an explicit grep -naP self-scan of all three touched files.
• check:phantom-deps and changeset:check (fixed group + no-major) green.

Changeset, by .d.ts measurement

@object-ui/plugin-grid — patch. Built both ways with dist/ and the tsbuildinfo cleared between builds: all 28 .d.ts files are byte-identical, aggregate 98e66ae4d758494d29d8e0474d8153f568b585b0ced8768607bcb597f3d9eaa8 before and after. Module-local, the #4496 precedent. Never major.

Scope

Only the one call site plus its explanatory comment. The two #4544-threaded 'short' cells, LinkCell (#4531) and the kebab / rowCrudAffordances code are untouched — the diff is 6 insertions / 2 deletions in one hunk. packages/fields (#4272, landed), data-objectstack/metadata-admin (#4271), studio inspectors (#4527), DashboardRenderer/ListView (#4528), plugin-kanban (#4254), plugin-gantt (#4542) and content/docs/releases/ all untouched.

No out-of-scope findings: the surrounding fallback's currency branch already threads tenantCurrency, and the remaining branches are non-locale.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 13, 2026 8:01am

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	index-DzjZGRY7.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	25.13KB	5.40KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	38.46KB	10.17KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	489.32KB	108.45KB
core (index.js)	3.37KB	1.34KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	158.47KB	43.13KB
fields (index.js)	230.18KB	57.13KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.84KB	1.45KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.86KB	12.91KB
plugin-charts (index.js)	62.10KB	17.67KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	120.95KB	31.53KB
plugin-designer (index.js)	212.58KB	42.83KB
plugin-detail (index.js)	239.88KB	59.99KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	164.26KB	40.01KB
plugin-grid (index.js)	189.36KB	50.33KB
plugin-kanban (index.js)	48.62KB	13.42KB
plugin-list (index.js)	111.13KB	27.12KB
plugin-map (index.js)	18.16KB	5.81KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	41.16KB	10.96KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.08KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.73KB	7.96KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[yinlianghui]

PM step-7 复核 — ACCEPT (session_017Qqyix2QcnpUC9XeYVDzx3)

• The one-liner was CONFIRMED a one-liner by measurement, not assumption: renderRecordDetail is a plain arrow in the component body already closing over sibling scope, so the hook value is directly visible — no lifting, no dependency array. Site re-located by content with the 3-hit grep proving it the last un-threaded formatDate in the file.
• Red-first with the runner-measured basis stated up front (en cannot go red on this machine — labelled a PIN inside the file, not presented as evidence), and the de tenant-precedence case chosen precisely because '15. März 2024' matches neither the machine form nor zh — the can't-pass-by-coincidence standard.
• The reachability engineering is the report's best content: no dataSource so the value drives into the inference fallback rather than the already-fixed DateCellRenderer; keys named to match the branch's date spellings but non-system so they land in the regular section; and assertions read the PORTALED detail panel's textContent rather than container, closing the pass-for-the-wrong-reason hole a grid cell on a localized path would have opened.
• The shard-1 red was investigated to ground exactly per protocol — cross-package with no dependency edge, zero-change rerun green on the same head, local isolation green, base green — and contributed as a fresh occurrence ON flaky: DatasetWidget.dottedDimensionTable's "issues the ONE read" case asserts a fetch AFTER waiting only on the rendered cell #4487 rather than a twin card. The control-bytes re-run AFTER git add (the gate skips untracked files) is the kind of detail that keeps gates honest.
• dts 28-file byte-identity both ways → patch (fix(app-shell): organization & invitation UI translates its six English holdouts (#4474) #4496); full plugin-grid 64/595 green with fix(fields): the date formatter's last three en-US channels thread the display locale (#4272) #4544/fix(plugin-grid): the link column renders a real anchor when the host publishes record URLs (#4490) #4531 pins intact; eslint identical to baseline; CI 20/20 on per-job conclusions.

Auto-merge armed (squash) — landing verified per the merge-queue discipline.

---

Generated by Claude Code

---

Generated by Claude Code