feat(plugin-charts): 把 `drillDown` 声明成 ObjectChart 的 registry input (framework#5022) by xuyushun441-sys · Pull Request #3358 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-04T10:56:21Z

配套 PR,主单在 framework:objectstack-ai/objectstack#5022 / objectstack-ai/objectstack#5221

为什么

ObjectChart 一直在读 schema.drillDown —— 点一个柱子/扇区打开底层记录抽屉,靠的就是它。但这个 prop 两边都没声明过:协议里没有,这个 registry entry 里也没有。

SDUI save gate 校验页面 JSX 用的 manifest 是从这些 inputs 逐字复制出来的(manifestFromConfigs),所以一个作者写了 drillDown 会拿到一条 unknown-prop 诊断 —— 对着一个真的能工作的 prop。

framework#5022 声明了协议半边(ChartDrillDownSchema,发布在 react-tier <ObjectChart> 契约上);这个 PR 是渲染器半边,让 gate 跟它对上。

改了什么

1. registry inputs 加上 drillDown。

描述里只列 spec 声明的六个键 —— enabled / filter / title / target('drawer' | 'dialog')/ columns / maxRows。

刻意不列本仓与 table / pivot / metric widget 共享的更宽的 DrillDownConfig:ObjectChart 不读 mode / report / view / sort,也不实现 target: 'navigate'(它直接落回 drawer)。把它们摆进设计器面板等于在低一层重新打开 framework#5022 刚合上的那个口子。其中两个键更是任何渲染器都不读 —— objectui#3354。

2. (schema as any).drillDown 换成类型化读取(DrillDownConfig)。

再往下收窄到 spec 的 ChartDrillDown 留成 TODO,挂在版本 pin 上:本仓 @objectstack/spec pin 在 ^17.0.0-rc.2,而声明落在下一个 rc,今天 import 编译不过 —— 而在本地重新声明一份形状,正是会让两边漂移的那种 fork,所以没做。注释里写清了两个类型不是同一个集合及其原因。

测试

新增两条断言(packages/plugin-charts/src/index.test.ts):

registry 必须发布这个 prop(type: 'object');
描述必须覆盖六个已声明键,且不得出现 mode / report / navigate —— 第二条是防止下一次「顺手补全」把另一个 widget 的词汇搬进来。

pnpm --filter @object-ui/plugin-charts test       → 16 files / 133 passed
pnpm --filter @object-ui/plugin-charts type-check → clean

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ehu85kbvMcrNTUJjwxvLJ9

Generated by Claude Code

…nput (framework#5022) `ObjectChart` has read `schema.drillDown` all along — it is what opens the drawer of underlying records when a segment is clicked — but the prop was declared in neither the protocol nor this registry entry. The manifest the SDUI save gate validates page JSX against is built verbatim from these `inputs`, so an author writing the drill got an `unknown-prop` diagnostic for a prop that works. framework#5022 declares the protocol half (`ChartDrillDownSchema`, published on the react-tier `<ObjectChart>` contract); this is the renderer half. The published input describes the six keys the spec declares — `enabled`, `filter`, `title`, `target` ('drawer' | 'dialog'), `columns`, `maxRows` — and deliberately NOT the wider `DrillDownConfig` this repo shares with the table / pivot / metric widgets. `ObjectChart` reads none of `mode` / `report` / `view` / `sort`, and does not implement `target: 'navigate'` (it falls through to the drawer). Advertising them in the designer palette would re-open the gap framework#5022 just closed, one layer down. Two of those keys are read by no renderer at all — objectui#3354. The untyped `(schema as any).drillDown` becomes a typed `DrillDownConfig` read. Narrowing it further to the spec's `ChartDrillDown` is a TODO on the version pin: `@objectstack/spec` is pinned at `^17.0.0-rc.2` here and the declaration lands in the next rc, so the import would not compile today — and re-declaring the shape locally is exactly the fork that would let the two drift. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ehu85kbvMcrNTUJjwxvLJ9

vercel · 2026-08-04T10:56:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 4, 2026 10:56am

github-actions · 2026-08-04T10:58:03Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BjQOOu3S.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	477.09KB	104.71KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	226.73KB	55.54KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	60.83KB	17.25KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.01KB	28.86KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	230.77KB	56.86KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.25KB	39.55KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	104.94KB	25.32KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.55KB	10.59KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added plugin plugin: charts tests labels Aug 4, 2026

xuyushun441-sys mentioned this pull request Aug 4, 2026

feat(spec,lint): 声明 chart segment drill —— ChartDrillDownSchema,挂在真正读它的那一层 (#5022) objectstack-ai/objectstack#5221

Merged

xuyushun441-sys marked this pull request as ready for review August 4, 2026 11:00

xuyushun441-sys added this pull request to the merge queue Aug 4, 2026

Merged via the queue into main with commit 524a635 Aug 4, 2026
16 checks passed

xuyushun441-sys deleted the claude/issue-5022-drilldown-declare branch August 4, 2026 11:00

Navigation Menu

Uh oh!

feat(plugin-charts): 把 `drillDown` 声明成 ObjectChart 的 registry input (framework#5022) - #3358

feat(plugin-charts): 把 `drillDown` 声明成 ObjectChart 的 registry input (framework#5022)#3358
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-5022-drilldown-declare

xuyushun441-sys commented Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 4, 2026

为什么

改了什么

测试

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants