fix(actions): make 'Open' (opensInNewTab) feel instant, not stuck#1561
Merged
Conversation
The env-list 'Open' (sso_as_owner) pre-opened a blank tab, then awaited a slow SSO-handoff mint with no feedback — the tab looked frozen and the button gave nothing, so users re-clicked, spawning more blank tabs + requests; when the popup was blocked it silently hijacked the current tab after the long wait. Fixes (ObjectView + RecordDetailView): - Paint a '正在为你打开环境…' spinner into the pre-opened tab immediately, so it never looks blank/frozen during the mint. - Re-entrancy guard: ignore repeat clicks while the same action+record is in flight (no more duplicate tabs/requests). - Blocked-popup fallback: instead of silently navigating the current tab after the wait, show a 'popup blocked → 打开环境' toast with a one-click (fresh-gesture) open, preserving the control-plane tab. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the #1 control-plane UX complaint: clicking Open on an env pre-opened a blank tab, then awaited a slow SSO-handoff mint with no feedback → looked frozen → users re-clicked (more blank tabs/requests); when the popup was blocked it silently hijacked the current tab after the wait.
ObjectView + RecordDetailView:
🤖 Generated with Claude Code