Repository navigation
charts: count measures get fractional y-axis ticks (0.5, 0.8, 1.5 …) #11681
Description
Path: ② the capabilities an end user meets in the app — dashboards and charts | 缺项 | P2
Split by the triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) · session_01AavokzJ5DndAwitDXvKy4U from objectui#11672 (the 2026-10-06 console dogfood sweep, showcase, framework ce577ec4), item 9. Re-read on objectui main (848ba0e12f) before filing: still live, with no open duplicate. ⛔ Not a claim, ⛔ not a dispatch.
Triage: lands in packages/plugin-charts/src/AdvancedChartImpl.tsx (about :2818–:2845) and ChartImpl.tsx (about :105) ⇒ domain:ui; rationale: no axis declares integer ticks for an integer measure.
What happens
"Projects by Health" shows 0.8 / 1.5 / 2.3 / 3, "Tasks by Status" 0.5 steps, and "Invoices by Month" 0.8 … 3, as do Chart Gallery's charts. No chart sets allowDecimals.
Done when
- A count measure, or any integer-typed measure, gets integer ticks. Non-integer measures are unchanged.
- Pin: the measured charts render integer ticks, and a sum over currency keeps its decimals.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 6, 2026
Claim: PM loop round 1
Session:
session_01FngvPpdrnhHMdHHq6vwwjuAccount:
os-justinBranch:
claude/issue-11681-integer-measure-ticksWorktree:
objectui-issue-11681Domain:
domain:uiSeat:
domain:ui#2File surface: the chart value axes in
@object-ui/plugin-charts:src/AdvancedChartImpl.tsx(the<YAxis>sites, about:2567,:2673–:2674,:2799–:2845) andsrc/ChartImpl.tsx(about:105); the axis normalisation they read (src/normalizeChartSchema.ts:ticksFor/domainFor/NormalizedAxis), and the measure facts that decide integer-ness (src/ObjectChart.tsx's aggregate function, and a field's declared type, only as much as passing that fact to the axis needs); the tests beside them; and.changeset/11681-*.md(stop on breach; explain in the report)Container & model:
M,mode:subagent,model: opus(dispatch-gates --tier --repo objectstack-ai/objectui: no path-derived mandate; default tier)Clause-②: no
Thread-read: none
Serial constraints cleared:
noneblocking. No open PR touchespackages/plugin-charts/src/**. The release PR objectui#11600 touches onlyplugin-charts'CHANGELOG.md/package.jsonand a pending changeset. Open PRs objectui#11713 (app-shell) and objectui#11715 (@object-ui/types) were read. This seat's in-flight objectui#11676 remainder is onplugin-timeline/ the locale packs, and objectui#11680 is oncore's registry andcomponents' placeholders. Read 2026-10-06T12:44Z.Why
Clause-②: no: the fix derives integer ticks from what the chart already knows: acountaggregate, or an integer-typed measure field. It changes what a published chart renders on its value axis, and widens no accepted input and adds no export. If the dev finds that the integer fact cannot be read without a new schema key (for example anallowDecimalson the chart or axis schema), that is a widening. The dev stops and reportsneeds_decisionwith the four-axis frame rather than adding the key, and the seat amends this line if the key is ruled in.Generated by Claude Code
objectstack-fleet commentedon Oct 6, 2026
os-dev-report
{ "issue": 11681, "status": "needs_decision", "branch": "claude/issue-11681-integer-measure-ticks", "pr": null, "session": "session_01FngvPpdrnhHMdHHq6vwwju (mode:subagent, so this is the dispatching seat's id, from the Claude-Session line)", "premise_still_valid": true, "summary": "The defect is real: no value axis in the tree sets allowDecimals, and recharts 3.10.1 picks 0.75 steps over [0,3] and 0.5 steps over [0,2], which are the card's 0.8 / 1.5 / 2.3 readings. Every measured chart (Projects by Health, Tasks by Status, Invoices by Month, the Chart Gallery's cartesian widgets) is a dashboard dataset widget over an author-labelled count measure such as { name: 'task_count', label: 'Tasks', aggregate: 'count' }, and on that path the chart cannot see that the measure is an integer. The answer's fields[] types every measure 'number' and sets builtinAggregate only when the measure has no label (pinned producer-side); DatasetWidget never reads the dataset definition, and its only hand-off into plugin-charts is the bare type 'chart' node. Zone 1 rules out a new schema key, so I added nothing (no commit, no PR); the branch is pushed empty at 9ca3cac as the claim marker.", "tests": "Measurements only; nothing was implemented, so there is no ablation. (1) recharts 3.10.1 getNiceTickValues (the function the YAxis tick selector calls, tickCount 5), run with node in the worktree at 9ca3cac. Domain [0,3]: allowDecimals true gives [0,0.75,1.5,2.25,3], false gives [0,1,2,3,4]. Domain [0,2]: true gives [0,0.5,1,1.5,2], false gives [0,1,2,3,4]. Domain [0,2.5], a small currency sum: true gives [0,0.65,1.3,1.95,2.6]. The 'adaptive' niceTicks mode gives the same answers. Exit 0. (2) git grep -n allowDecimals -- packages apps examples at 9ca3cac: exit 1, 0 hits. Control: git grep -c tickFormatter on AdvancedChartImpl.tsx, exit 0, 12 hits. (3) Producer, read with git show at objectstack origin/main 1c563af4. enrichResultColumns in service-analytics' analytics-service.ts writes builtinAggregate only under the condition 'm.label == null'. The dataset executor pushes { name: m, type: 'number' } for every measure. query-dataset.test.ts pins 'an author-labelled measure (\"Tasks\") keeps its text and carries NO builtinAggregate' on exactly the showcase measure shape. NOT MEASURED: that pin was read, not run, because the shared objectstack checkout has no install and no packages/spec/dist. (4) Showcase metadata at origin/main: the three measured widgets bind project_count / task_count / invoice_count, each declared aggregate 'count' with a label. (5) Registry: view:chart is registered with skipFallback, so the bare 'chart' key resolves to ChartRenderer (plugin-charts:chart). That is DatasetWidget's whole hand-off.", "mcp_calls": "0 (no MCP GitHub tool used)", "api_writes": "1: POST /repos/objectstack-ai/objectui/issues/11681/comments (this report, through scripts/pm/post-stamped.mjs and the fleet relay). Not a REST write: one git push of the empty branch (claim marker and write probe).", "gates": [ { "cmd": "node -e (recharts getNiceTickValues probe over [0,2], [0,3], [0,2.5])", "exit": 0, "head": "9ca3cac", "kind": "measurement" }, { "cmd": "git grep -n allowDecimals -- packages apps examples", "exit": 1, "head": "9ca3cac", "kind": "measurement, 0 hits" }, { "cmd": "git grep -c tickFormatter -- packages/plugin-charts/src/AdvancedChartImpl.tsx", "exit": 0, "head": "9ca3cac", "kind": "positive control, 12 hits" } ], "gate_families": "None owed. The diff has zero files, so no objectui gate family reads it. The order's clue list (plugin-charts build/test/type-check/lint, check:new-line-citations, check:control-bytes, the changeset checks, the governed-queue guard) applies to the implementation PR that follows a ruling.", "line_budget": "Not applicable: no diff, and no skills/** file touched.", "files_changed": [], "deviations": [ "File surface: the producer that lacks the fact is outside the claim's surface. It is @object-ui/plugin-dashboard's DatasetWidget, which builds the chart node, together with objectstack's service-analytics, which describes the answer's columns. The order allows a producer-side fix, but both producer routes are the open decision (question 1), so I edited neither.", "One git fetch origin main in the shared objectstack checkout, to read origin/main. It touched refs only, no files.", "The producer pin was read at origin/main, not run (NOT MEASURED; the reason is under tests).", "No conflict found between the order and os-dev.md." ], "decision_dedupe_words": ["integer ticks", "allowDecimals", "fractional y-axis ticks", "measure column aggregate", "count measure axis"], "open_questions": [ { "question": "Q1: Where does a dataset-bound chart learn that a measure is integer-valued? On the measured path (a dashboard dataset widget over an author-labelled count measure), nothing the chart receives says so. The answer's fields[] entry is { name, type: 'number', label }. The type is always 'number' (the DimensionType vocabulary has no integer member), and builtinAggregate appears only when the measure has no label. DatasetWidget never reads the dataset definition. ObjectChart's dataset path does: it already fetches meta/dataset for labels and colours.", "options": [ "A. The producer puts it on the wire (objectstack first, then objectui). enrichResultColumns is the one seam that already describes measure columns from the dataset definition (label, format, currency, percentScale, builtinAggregate). It would add the measure's aggregate to every measure column. A1 is the raw aggregate (count or count_distinct means integer). A2 is the resolved decimal places: 0 for count/count_distinct, the source field's resolveFieldScale for sum/min/max, and absent for avg and derived measures. 实际业务需求: covers every measured chart. In the example apps, 10 of the 11 single-line cartesian dashboard widgets plot a *_count measure declared aggregate 'count'. It also covers every other dataset reader at once (ObjectChart's dataset path, DatasetPreview, the draft-preview answer). 项目长远合理性: contract-first, and decided once where the facts already live (the server holds m.aggregate and sourceFieldMeta). It is a response-schema member, not an authoring key. 防 AI 写错: there is nothing new to author; the fact comes from the measure's own required aggregate. 创业阶段不扩散需求: one response member, a spec bump, and two PRs in two repos with objectstack first. A1 is the narrow spelling.", "B. The client fetches it. DatasetWidget reads meta/dataset/NAME (the same read ObjectChart's dataset path already makes) to get measures[].aggregate. For the measure field's scale it uses the base object schema it already loads. 实际业务需求: covers the measured charts. 项目长远合理性: it derives a column fact a second time, on the client, next to the server seam built to own it. It adds a metadata read for every dataset widget, and a draft-preview answer can disagree with the published definition the widget reads. 防 AI 写错: same as A, nothing to author. 创业阶段不扩散需求: one repo and no spec change, but a new network read on every dashboard.", "C. Derive it from the values: integer ticks whenever every value on the axis is a whole number. 实际业务需求: covers the measured charts. 项目长远合理性: it guesses from the data, which is the approach the percent-scale chain retired. The axis flips when one fractional row appears, and a whole-number currency sum on a small domain loses its decimals, so the card's currency pin fails in that case. 防 AI 写错: the renderer asserts a fact nothing declared. 创业阶段不扩散需求: cheapest. It is also outside this order's Zone 1, which requires the fact to come from what the chart already declares.", "D. Land only the paths where the aggregate is already in reach (ObjectChart with objectName and aggregate.function, plus the definition its dataset path already fetches) and leave dataset widgets fractional. 实际业务需求: misses every measured chart. 项目长远合理性: still needs the carrier from Q2. 防 AI 写错: neutral. 创业阶段不扩散需求: small, but fixes none of the charts the card measured." ], "recommendation": "A1. It is the only contract-first option, and it serves every dataset consumer from the seam that already describes measure columns (项目长远合理性, 防 AI 写错). It covers every measured chart (实际业务需求). It is also the narrowest spelling: only count/count_distinct, which is all the example apps use (创业阶段不扩散需求; see Q3). If a cross-repo change is not wanted now, B is the fallback, at the cost of a second derivation and an extra read per widget." }, { "question": "Q2: Whatever Q1 decides, how does the fact reach plugin-charts' value axis? Every producer hands the chart over as a node. DatasetWidget renders a bare type 'chart' node, which resolves to ChartRenderer. ObjectChart passes ChartRenderer a schema object. A new ChartRenderer prop also counts as a node key, because SchemaRenderer spreads a node's remaining keys as props. So the carrier has to be a member on the chart node or an unregistered internal component. The bar-chart component (ChartImpl) gets only inline data and a dataKey, and nothing produces measure facts for it, so it keeps recharts' default under every option.", "options": [ "a. A renderer-internal member on the internal (dataKey) arm of ChartRendererProps.series. normalizeSeries reads it into NormalizedSeries, NormalizedAxis derives an integer flag per value slot (a slot is integer only when every series bound to it is), and each value YAxis and number XAxis passes allowDecimals as the negation of that flag. A dual-axis or combo chart then decides each side on its own. This follows the chartType precedent: internal-only and refused by name on the authoring face (the annotate-and-pin state objectui#7744 records). 实际业务需求: carries A or B to every cartesian family. 项目长远合理性: one normalisation point, inside the internal/authoring split that is already documented. 防 AI 写错: needs the by-name refusal on the authoring face; otherwise an AI can author the member and the renderer honours it. 创业阶段不扩散需求: no authored surface.", "b. A declared member on the chart node's authoring face (a spec ChartSeries row). 实际业务需求: same reach. 项目长远合理性: widens the authored contract with a fact no author should write. 防 AI 写错: worst, because an author or AI can declare integer ticks on a currency sum. 创业阶段不扩散需求: a new authored key, which this order's Zone 1 excludes.", "c. ObjectChart renders an unregistered internal wrapper of ChartRenderer that takes the fact as a prop (package-local, so no node can reach it). DatasetWidget still needs (a). 项目长远合理性: two channels for one fact. 防 AI 写错: the internal half cannot be authored. 创业阶段不扩散需求: more code than (a) alone." ], "recommendation": "a. It reuses the existing internal-carrier shape, keeps the fact off the authored contract, and decides integer-ness once on the normalised axis (项目长远合理性, 创业阶段不扩散需求), as long as the authoring face refuses the member by name (防 AI 写错)." }, { "question": "Q3: Is the card's second half, sum/min/max over an integer-typed field, in scope now? In the spec an integer field is a number field with a declared scale: 0 (resolveFieldScale); there is no integer type. No dataset measure in the example apps sums such a field. The summed fields are currency (budget, spent, annual_revenue), a summary field (invoice total) or a number with no scale (estimate_hours).", "options": [ "A. Only count and count_distinct now; retire the integer-field half from this card because nothing uses it. 实际业务需求: covers every measured chart. 项目长远合理性: A1's raw aggregate is enough, and A2 can follow if a producer appears. 防 AI 写错: neutral. 创业阶段不扩散需求: the narrow cut.", "B. Both halves now. That needs Q1's A2 (the source field's scale on the wire). 实际业务需求: no instance in the examples. 项目长远合理性: complete against the card's wording. 防 AI 写错: neutral. 创业阶段不扩散需求: a speculative capability with no demand." ], "recommendation": "A. The integer-field half has no producer in the example apps (实际业务需求, 创业阶段不扩散需求), and the narrow cut needs only A1." } ], "out_of_scope_findings": [ "carrier: the implementation PR that follows a ruling on this card (it will touch packages/plugin-charts/src/normalizeChartSchema.ts) · noted, not filed. normalizeSeries' docblock, in the paragraph headed 'chartType is the INTERNAL spelling', cites ChartRenderer.tsx by line address for the internal series shape, and that address is already stale. AGENTS.md #11 says to repair it when the file is touched. Dedupe words: normalizeChartSchema line address, ChartRenderer internal series citation, cross-file line citation." ] }Generated by Claude Code
objectstack-fleet commentedon Oct 6, 2026
pm:retriage: where a dataset-bound chart learns that a measure is an integer. The fix needs a carrier this card's direction did not name, and the measured answer is cross-repodomain:uiexecution seat 2 ·session_01FngvPpdrnhHMdHHq6vwwju(os-justin) · 2026-10-06T12:57Z.Release: claim
6016530604(session_01FngvPpdrnhHMdHHq6vwwju,os-justin) · cause: the dev measured the defect, and every fix route needs a decision the card does not settle (dev reportneeds_decisionon this card) · destination:pm:queuewithpm:retriage, for triage to answer the questions below or route them to the maintainer's box. The next claim starts from that answer. Nothing was committed; the branchclaude/issue-11681-integer-measure-ticksis pushed empty at9ca3cac.What was measured.
allowDecimals(git grep0 hits; positive controltickFormatter: 12). recharts 3.10.1'sgetNiceTickValuesgives[0, 0.75, 1.5, 2.25, 3]over[0, 3]and[0, 0.5, …, 2]over[0, 2], which are the card's readings. WithallowDecimals: falseit gives[0, 1, 2, 3, 4].{ name: 'task_count', label: 'Tasks', aggregate: 'count' }.fields[]entry is{ name, type: 'number', label }, andDimensionTypehas no integer member;builtinAggregateis set only when the measure has no label (objectstackservice-analytics,enrichResultColumns, pinned producer-side);DatasetWidgetnever reads the dataset definition, and hands plugin-charts a baretype: 'chart'node.Asked of triage (the dev's three questions; recommendations are the dev's, each argued on the four axes in the report):
service-analytics'enrichResultColumns, the seam that already writeslabel/format/currency/percentScalethere.count/count_distinctmean integer. This is a response-schema member, not an authoring key, and it covers every dataset reader. It means objectstack first, then objectui.meta/dataset/NAMEinDatasetWidget, asObjectChart's dataset path already does. One repo, but a second derivation and an extra read per widget.ChartRendererProps.series, refused by name on the authoring face (thechartTypeprecedent, objectui#7744). The normalised axis derives a per-slot integer flag, and each value axis passesallowDecimalsas its negation, so each side of a dual-axis chart decides for itself.count/count_distinctonly. No example-app measure sums ascale: 0field, and an integer field is a number field withscale: 0(there is no integer type).Seat's lean: Q1 A1, Q2 a, Q3 A. It is contract-first and decided once where the facts live, and nothing becomes authorable. It is cross-repo, which is why it is routed rather than ruled here. If triage wants it inside objectui alone, Q1 B with Q2 a is the fallback.
Recorded for the implementing PR, not filed:
normalizeChartSchema.ts'normalizeSeriesdocblock citesChartRenderer.tsxby a line address that is already stale (AGENTS.md #11: repair it when the file is touched).Generated by Claude Code
3 remaining items
feat(spec,analytics): a dataset answer's measure column states its ag…
objectstack-fleet commentedon Oct 14, 2026
Restart:
pm:on-hold→pm:queue·domain:uiseat 1 ·session_01CsyMRsFJBKNEMa4oPY1b5zThe held condition is met. objectui#12030 landed as PR #12337 (
mainc5406c2), so objectui now resolves@objectstack/*18.0.0-next.0. The measurement is the dev's held-card table in6151240488on objectui#12030; it was run against thenext.0tarball and the installed tree, with17.7.0as the negative control.c5658133fc). It is met:c5658133fcis an ancestor ofnext.0's tag commitd889448b93.The card returns to
pm:queuefor its lane with its grade unchanged. ⛔ Not a claim. Under the maintainer's current p1-only instruction for this seat (6149890064on objectui#5560), it waits in the queue unless it is p1.Generated by Claude Code
objectstack-fleet commentedon Oct 14, 2026
Claim: PM loop round 1
Session:
session_01XVp19E1MYUTFM3dnkwz8gBAccount:
baozhoutao(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/issue-11681-integer-measure-ticks-r2Worktree:
objectui-issue-11681Domain:
domain:uiSeat:
domain:ui#2File surface: revised 2026-10-14T19:20Z after the dev measured that the ruled route (triage
6017839148, Q2 a) cannot be carried in the chart files alone. It now coverspackages/core/src/utils/chart-series.ts(ChartResultField/ChartSeriesBindingcarry the measure'saggregate),packages/plugin-dashboard/src/DatasetWidget.tsx, and inpackages/plugin-charts/src/:ChartRenderer.tsx,normalizeChartSchema.ts,AdvancedChartImpl.tsxandChartImpl.tsx. It also covers the by-name series refusal on the authoring face inpackages/types, plus the tests of all of these (stop on breach; explain in the report)Container & model:
S,mode:subagent,model: opus(default tier;dispatch-gates --tier --repo objectstack-ai/objectuireads no path-derived mandate)Clause-②: to be measured. The surface now touches
@object-ui/core's exported chart-series types and@object-ui/types's authoring face. The dev measures whether a published export or accept set moves, and a yes takes the contract review before the queue.Responsibility:
objectui's plugin-charts draws a count axis with fractional ticks | no platform path covers it: tick choice is the renderer's | every dashboard chart over a count or integer measure; measured on the showcase dashboardsThread-read: 6159861162
Serial constraints cleared: no in-flight claim names the plugin-charts axis files (read 2026-10-14T19:09Z). The earlier claim
6016530604(seat 2,session_01FngvPpdrnhHMdHHq6vwwju) ended when the card went topm:on-hold, and the restart6159861162returned it topm:queuewith no assignee. Its branchclaude/issue-11681-integer-measure-ticksis read for prior work, not reused.Generated by Claude Code
objectstack-fleet commentedon Oct 14, 2026
os-dev-report
{ "issue": 11681, "status": "blocked", "branch": "claude/issue-11681-integer-measure-ticks-r2", "pr": null, "session": "session_01XVp19E1MYUTFM3dnkwz8gB (mode:subagent, the dispatching seat's id from the Claude-Session line)", "premise_still_valid": true, "summary": "The defect is still live on origin/main fc211e817 (no value axis sets allowDecimals), and the producer half has landed: the installed @objectstack/spec 18.0.0-next.0 declares AnalyticsResult fields[].aggregate on every dataset measure column, labelled or not. But the ruled route (triage 6017839148: Q1 A1, Q2 a, Q3 A) cannot be carried inside this claim's file surface (AdvancedChartImpl.tsx, ChartImpl.tsx and their tests). The value axes only see NormalizedSeries, and normalizeSeries copies a fixed list of keys, so it drops any member it does not name. DatasetWidget (the measured charts) builds its series with core's buildChartSeries, whose ChartSeriesBinding is only dataKey and label. So the fact has to be carried through files outside the surface, and the only in-surface option is guessing from values, which C ruled out. Per the order (anything else: stop and report) I stopped. Nothing is committed; the branch is pushed empty at fc211e817 as the claim marker. The PM needs to widen the claim's file surface (list under open_questions) or rule differently.", "tests": "Measurements only; no implementation, so no ablation and no gates run. (1) git grep -c allowDecimals -- packages apps examples at fc211e817: exit 1, 0 hits. Control: git grep -c tickFormatter on AdvancedChartImpl.tsx, exit 0, 12 hits. (2) Installed spec 18.0.0-next.0, src/api/analytics.zod.ts: fields[] declares aggregate (AggregationFunction, optional): 'Set on every measure column of a dataset answer ... whose measure declares an aggregate, its __compare column included. Absent on dimension columns and on derived measures'. (3) normalizeChartSchema.ts normalizeSeries starts from const out: NormalizedSeries = { dataKey } and copies named keys only (NormalizedSeries: dataKey, label, chartType, variant, opacity, dashArray, stack, yAxis, color). (4) core chart-series.ts: ChartSeriesBinding is { dataKey, label }; buildChartSeries callers are DatasetWidget.tsx (plugin-dashboard), ObjectChart.tsx (plugin-charts) and DatasetReportRenderer.tsx (plugin-report). DatasetWidget's measures-on-axis branch builds its single series inline as { dataKey: MEASURE_VALUE_KEY, label }, and its comparison overlay series are rebuilt from dataKey and label.", "mcp_calls": "0 (no MCP GitHub tool used)", "api_writes": "1: POST /repos/objectstack-ai/objectui/issues/11681/comments (this report, through objectstack scripts/pm/post-stamped.mjs). Not a REST write: one git push of the empty branch (claim marker and write probe).", "gates": [ { "cmd": "git grep -c allowDecimals -- packages apps examples", "exit": 1, "head": "fc211e817", "kind": "measurement, 0 hits" }, { "cmd": "git grep -c tickFormatter -- packages/plugin-charts/src/AdvancedChartImpl.tsx", "exit": 0, "head": "fc211e817", "kind": "positive control, 12 hits" } ], "gate_families": "None run. The diff has zero files. The order's list (plugin-charts type-check, vitest, narrowed lint, the pre-tsc battery, check-changeset-fixed, the ablation) applies to the implementation PR after the surface is widened.", "line_budget": "Not applicable: no diff, no skills/** file touched.", "files_changed": [], "deviations": [ "File surface: the ruled route needs files outside the claim's surface, so I stopped as the order says. No file was edited.", "No conflict found between the order and os-dev.md." ], "open_questions": [ { "question": "Widen the claim's file surface to the ruled route (Q2 a, from triage 6017839148)? These are the files it needs, each measured: (1) packages/core/src/utils/chart-series.ts: ChartResultField gains aggregate (now in the spec, so the spec-parity pin allows it) and ChartSeriesBinding carries it from the measure column (a pivoted single-measure chart takes the one measure's aggregate). (2) packages/plugin-dashboard/src/DatasetWidget.tsx: the measures-on-axis series is integer only if every plotted measure is count or count_distinct, and the comparison overlay copies its primary's member. (3) packages/plugin-charts/src/ChartRenderer.tsx: the internal (dataKey) arm of ChartRendererProps.series gets the member. (4) packages/plugin-charts/src/normalizeChartSchema.ts: normalizeSeries reads it, and a per-slot integer flag is derived (a slot is integer only if every series bound to it is). The stale line address in the normalizeSeries docblock gets fixed in the same edit, as triage asked. (5) AdvancedChartImpl.tsx: every value axis (vertical YAxis left/right, and the horizontal-bar number XAxis) gets allowDecimals as the negation of that flag. (6) The by-name refusal on the authoring face (packages/types, where the chartType series refusal lives, plus its test), so an author cannot declare it. Optional: ObjectChart.tsx and plugin-report DatasetReportRenderer.tsx pass state.fields to buildChartSeries already, so they would get it for free. Plus the changeset.", "options": [ "A. Widen the surface to (1) through (6) plus the changeset and re-dispatch this branch. One PR across core, plugin-dashboard, plugin-charts and types. It covers every measured chart.", "B. Split it: this card keeps the plugin-charts half (3)(4)(5) plus the types refusal (6), and a sub-card carries the producers (1)(2). Until the sub-card lands, the measured charts stay fractional, so this card's pin cannot be met in the first PR.", "C. Keep the two-file surface. Nothing in AdvancedChartImpl/ChartImpl can know a measure's aggregate except from the values, which ruling C rejects. Not viable." ], "recommendation": "A. The route is already ruled, and the card's pin (the measured dashboard charts) needs the producer half, so splitting only delays the pin. It is one fact through one channel, in one PR." } ], "out_of_scope_findings": [] }Generated by Claude Code
objectstack-fleet commentedon Oct 14, 2026
os-dev-report
{ "issue": 11681, "status": "done", "branch": "claude/issue-11681-integer-measure-ticks-r2", "pr": "https://github.com/objectstack-ai/objectui/pull/12387", "session": "session_01XVp19E1MYUTFM3dnkwz8gB (mode:subagent, the dispatching seat's id from the Claude-Session line)", "premise_still_valid": true, "summary": "Implemented the ruled route (triage 6017839148: Q1 A1, Q2 a, Q3 A) inside the widened surface. core buildChartSeries copies each result field's aggregate onto its series. DatasetWidget keeps it on the comparison overlay and on the transposed dimensionless series (only when every measure shares one aggregate). ChartRenderer's internal dataKey arm declares the member and normalizeSeries reads it. In AdvancedChartImpl, yAxisSpecProps (every cartesian value axis, including the horizontal-bar number XAxis, each dual-axis side separately) sets allowDecimals false only when every series on that slot plots count or count_distinct; any other slot is byte-identical to before. types refuses an authored series aggregate by name (zod retirementTombstone arm plus TS ?: never). Radar was left alone: recharts 3.10.1 PolarRadiusAxis already defaults allowDecimals false. ChartImpl gets no measure fact. ObjectChart.tsx and DatasetReportRenderer.tsx needed no edit and compile unchanged. Clause-② measured yes: core exports widen, and the types accept set narrows, with the parse flip shown by ablation.", "tests": "At merged head d62511d7b: full projects of types, core, plugin-charts and plugin-dashboard under the verify lock: Test Files 851 passed (851), Tests 17328 passed, 42 skipped, VERDICT command-exit 0. Closure build plus type-check of all four packages (each compiles its tests): exit 0. New pins: ChartRenderer.integerMeasureTicks-11681 (10 DOM-tick cases), DatasetWidget.integerMeasureTicks-11681 (9 full-chain DOM-tick cases with the measured widget shapes, a currency-sum control, a comparison overlay and a dimensionless chart), chart-series.aggregate-11681 (core) and chart-series-aggregate-refusal-11681 (types). Ablation, once, through objectstack scripts/ablation-replace.mjs: deleted the allowDecimals spread in yAxisSpecProps (anchor 1 to 0, blob 1281a215f666 to 565d0292ce6b). Result: 12 failed and 7 passed of 19; every integer case red, every control green. Restore was verified: blob equals HEAD and git diff HEAD is empty. Resolution goes through the vitest src alias for @object-ui/plugin-charts and core, so no dist preflight applies. The Clause-② parse flip was a second one-off mutation that renamed the zod member away: 4 refusal cases red (the series and node parse green with the key stripped), then restored.", "mcp_calls": "0 (no MCP GitHub tool used)", "api_writes": "3 relayed writes in all (fleet-write as objectstack-fleet[bot]): round 1 POST /repos/objectstack-ai/objectui/issues/11681/comments (comment 6176279787); round 2 POST /repos/objectstack-ai/objectui/pulls (draft PR 12387) plus POST /repos/objectstack-ai/objectui/issues/12387/assignees in the same pr_create action; round 2 POST /repos/objectstack-ai/objectui/issues/11681/comments (this report). Not REST writes: git pushes of the branch. Zero label writes (objectui's labeler sets path labels; none were named).", "gates": [ { "cmd": "closure build + pnpm --filter types/core/plugin-charts/plugin-dashboard type-check", "exit": 0, "head": "d62511d7b" }, { "cmd": "pnpm exec vitest run --maxWorkers=2 packages/types/ packages/core/ packages/plugin-charts/ packages/plugin-dashboard/", "exit": 0, "head": "d62511d7b", "kind": "851 files, 17328 passed" }, { "cmd": "eslint --no-inline-config over the 11 changed TS files", "exit": 0, "head": "d62511d7b", "kind": "0 errors; not type-aware, so it is a narrowing that excludes nothing" }, { "cmd": "pnpm check:phantom-deps, self-import, unreferenced-sources, doc-example-readers, handler-key-reads, side-effects-array, element-data-source-declaration, spec-symbols, action-forward-parity, designer-field-key-parity, icon-record-names, i18n-keys, i18n-drift, i18n-designer-parity, control-bytes, new-line-citations", "exit": 0, "head": "d62511d7b" }, { "cmd": "pnpm check:spec-floors", "exit": 1, "head": "d62511d7b", "kind": "known main-side failure objectui#12334 (The scan collapsed), recorded, not fixed" }, { "cmd": "node scripts/check-changeset-fixed.mjs / check-changeset-presence.mjs / check-changeset-no-major.mjs", "exit": 0, "head": "d62511d7b" }, { "cmd": "ablation: delete allowDecimals spread", "exit": 1, "head": "6499e3591", "kind": "expected red: 12 failed / 7 passed, restored clean" } ], "gate_families": "Hand-derived, as the order says (dispatch-gates cannot derive objectui yet). The objectui name for check:nul-bytes is check:control-bytes; pnpm check:nul-bytes exits 254 here as a missing script, so I ran control-bytes instead. Full pnpm lint is left to CI.", "line_budget": "Not applicable: no skills/** file touched.", "files_changed": [ ".changeset/11681-integer-measure-ticks.md", "packages/core/src/utils/chart-series.ts", "packages/core/src/utils/chart-series.aggregate-11681.test.ts", "packages/plugin-dashboard/src/DatasetWidget.tsx", "packages/plugin-dashboard/src/__tests__/DatasetWidget.integerMeasureTicks-11681.test.tsx", "packages/plugin-charts/src/ChartRenderer.tsx", "packages/plugin-charts/src/normalizeChartSchema.ts", "packages/plugin-charts/src/AdvancedChartImpl.tsx", "packages/plugin-charts/src/ChartRenderer.integerMeasureTicks-11681.test.tsx", "packages/types/src/data-display.ts", "packages/types/src/zod/data-display.zod.ts", "packages/types/src/__tests__/chart-series-aggregate-refusal-11681.test.ts" ], "deviations": [ "origin/main moved during the round (to 0a63422ec), so I merged it into the branch (merge commit d62511d7b; no rebase, no force-push) and re-ran build, type-check and the four full suites at the merged head.", "ChartImpl.tsx is in the widened surface but is unchanged: the inline bar component receives no measure fact.", "The PR body footer uses the role file's session-URL form, not the harness's suggested robot-emoji line; commit trailers are the model-free pair AGENTS.md prescribes, not the harness's model-named Co-Authored-By." ], "open_questions": [], "out_of_scope_findings": [] }Generated by Claude Code
objectstack-fleet commentedon Oct 14, 2026
Review: ACCEPT — objectui PR #12387 ·
domain:uiseat 2 ·session_01XVp19E1MYUTFM3dnkwz8gB· 2026-10-14T21:02ZReviewed on GitHub at head
6ad6b91, against triage's ruling6017839148(Q1 A1, Q2 a, Q3 A), this card's Done-when, the revised claim6176207338, and the contract reviews on this PR, not against the dev's report.main. Its body opensFixes #11681, the only closing keyword, followed byClause-②: yes. The governed sweep reads NOT governed, 632 lines (+615 / −17).6178396630:Served-tier: CONTRACT_REVIEW_TIER,Head-sha6ad6b91886…,Local-runs: none.d62511d(6177951530) was FAIL on one ground:plugin-charts: patchwhere the widenedChartRendererPropsseries arm andNormalizedSeriestakeminor, as objectui#8086 shipped. The patch round changed only the changeset (nowminor, naming the widened arm). The seat wrote the corrected three-movement contract section into the PR body.aggregateonChartResultField/ChartSeriesBinding, plusINTEGER_AGGREGATES/isIntegerAggregate;aggregateby name (tombstone plus?: never), as the ruling requires.minor; plugin-dashboard ispatch.buildChartSeriescopies each result field's aggregate onto its series;yAxisSpecPropssetsallowDecimals: falseper value-axis slot only when every series on it plotscount/count_distinct, horizontal-bar X and each dual-axis side included;sumkeeps its decimals;filter=latest), all 12 test shards included.needs:contract-reviewis removed in the same stroke. Next:pr_ready+automerge_enable.Generated by Claude Code
objectstack-fleet commentedon Oct 14, 2026
Landed ·
domain:uiseat 2 ·session_01XVp19E1MYUTFM3dnkwz8gB· 2026-10-14T21:20Zmain96fcf30. The card closedcompletedby the PR'sFixes #11681, which is the only closing keyword. No other card closed with it.origin/main, all 12 files the PR touches are blob-identical to the accepted head6ad6b91, which passed contract review6178396630. They span corechart-series.ts, DatasetWidget, the plugin-charts renderer/normalizer/axis files, thepackages/typesrefusal, the four pins and.changeset/11681-integer-measure-ticks.md.pm:dispatchedis removed in the same stroke as this comment.Generated by Claude Code