Skip to content

fix(examples): showcase home page "Create Task" button now carries element:button's inline action #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-project-manager merged 1 commit into from
Aug 8, 2026
+14 −1
Merged

fix(examples): showcase home page "Create Task" button now carries element:button's inline action #6737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion examples/app-showcase/src/ui/pages/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,20 @@ export const ComponentGalleryPage = definePage({
],
},
},
{ type: 'element:button', properties: { label: 'Create Task', actionName: 'showcase_new_task' } },
// The page's primary CTA. `element:button` carries an **inline** action
// (`action`, an InlineActionSchema) — it is NOT a by-name reference to a
// registered object action; that is `action:button`. This block used to
// author `actionName: 'showcase_new_task'`, a key `ElementButtonPropsSchema`
// never declared: the strip-mode parse dropped it, the renderer reads only
// `props.action`, and its `handleClick` opens with `if (!action) return` —
// so the button rendered, was clickable, and the click did nothing at all
// (no request, no dialog, no navigation). #6597.
//
// `type: 'modal'` + a string `target` is resolved page-first, then object
// (objectui `useActionModal.resolveModalTarget`); `showcase_task` names no
// page, so it lands on the object and opens the Task create form — which is
// what a button labelled "Create Task" should do.
{ type: 'element:button', properties: { label: 'Create Task', icon: 'plus', action: { name: 'showcase_new_task', type: 'modal', target: 'showcase_task', refreshAfter: true } } },
],
},
{
Expand Down
Loading