chore(qa,objectql): 摘除 dogfood 无消费的 driver-memory devDep + 清扫 1 处 stub 注释散文 (#5829) - #5836
Merged
Merged
Conversation
…de-reference driver-memory in one stub comment (#5829) #5704 收口尾单(批次 2/3 已合入 PR #5797/#5806),两件留档尾项: 1. `packages/qa/dogfood` 的 `@objectstack/driver-memory` devDep:#5715(批次 0) 把 read-coercion 一致性测试的 memory 臂移除后,全包已零真实 import (`git grep -in memory -- packages/qa/dogfood` 只剩 README 的 "in-memory SQLite" 散文与 read-coercion-conformance.test.ts:9 记录移除原因的 注释)。摘除声明 + lockfile 随动(仅该一条 importer 链接)。 2. `protocol-batch-atomic.test.ts` 的 `makeSnapshotDriver()` 头注释把这个本地 手写 stub 说成「the same shape driver-memory uses」——packages/objectql 根本 不依赖 driver-memory,这类措辞正是 #5704 Phase 1 survey 里让 `grep -i memory` 虚高的来源。按 #5797 同款原则改写为指涉 stub 自身。 `protocol-data.test.ts:759` 经复核**原样保留**:那一句 「Mirror of #3948's rule for driver-memory: an unapplied filter must not look like a satisfied one」指的是真实 driver-memory 包里真实存在的不变量 (`filter-refusal.ts`、`memory-driver.ts:753/792/817`、 `memory-filter-ast-vocabulary.test.ts`),属于 #5797 已开的例外类 (描述真实驱动族行为的散文一律保留),不是把 stub 说成 driver-memory。 零行为变更。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WyvqvKMG6asi9aXjKE6xtx
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 2 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
August 6, 2026 07:53
This was referenced Aug 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5829
Part of #5704 收口阶段(批次 2/3 已合并,PR #5797 / #5806),本单是留档的两件尾项。
任务 1:摘除
packages/qa/dogfood的 driver-memory devDep ✅摘前按要求全包复核零真实消费(以
origin/main为准):零
import ... from '@objectstack/driver-memory';唯一提及是 #5715 移除 memory 臂时留下的说明性注释(散文不算消费)。摘除该行后pnpm install,lockfile 只掉了这一条 importer 链接:任务 2:附录散文清扫 —— 实测后只改了 1 处,另 1 处原样保留
git grep -n "driver-memory" origin/main -- packages/objectql/src/protocol-batch-atomic.test.ts packages/objectql/src/protocol-data.test.ts命中的两处,逐处读上下文后判定:改写 ——
protocol-batch-atomic.test.ts:23:该注释头的是makeSnapshotDriver()这个本地手写 stub,原文「the same shapedriver-memoryuses」正是 #5704 Phase 1 survey 里让grep -i memory虚高的措辞(packages/objectql根本不依赖 driver-memory)。按 PR #5797 同款原则改写为指涉 stub 自身,保留其实质信息(这是真会回滚的快照式事务语义,不是玩具):保留 ——
protocol-data.test.ts:759:按 PM 派发情报「先读上下文再判,若描述的是真实驱动族语义就原样保留,不要为改而改」复核后,判定属于 #5797 已开的例外类。该句是 #4134 小节 banner 的收尾:它没有描述任何 stub —— 该小节的 harness 是纯
vi.fn()engine,连 driver 都没有;这句是引用真实@objectstack/driver-memory包里真实存在、且今天仍在被强制执行的不变量作为先例。证据(均在origin/main):packages/drivers/driver-memory/src/filter-refusal.ts:64「A filter with an operator outside VALID_AST_OPERATORS is silently dropped, not rejected — single-condition views return unfiltered results #3948 made the two backends AGREE that an uncompilable filter ...」packages/drivers/driver-memory/src/memory-driver.ts:753 / 792 / 817(三处 A filter with an operator outside VALID_AST_OPERATORS is silently dropped, not rejected — single-condition views return unfiltered results #3948 锚点)packages/drivers/driver-memory/src/memory-filter-ast-vocabulary.test.ts:2「Filter-AST vocabulary parity, and no-silent-drop. (A filter with an operator outside VALID_AST_OPERATORS is silently dropped, not rejected — single-condition views return unfiltered results #3948)」packages/drivers/driver-memory/CHANGELOG.md:443「fix(driver-sql,driver-memory): an uncompilable filter now throws instead of matching everything (A filter with an operator outside VALID_AST_OPERATORS is silently dropped, not rejected — single-condition views return unfiltered results #3948)」改写它会把一条准确的跨包交叉引用改成假信息,故原样保留。因此 diff 是 3 个文件而非 issue 预估的 4 个(package.json + lockfile + 1 个测试文件),这是复核后的实测结果。
边界遵守
packages/runtime的 driver-memory devDep 与undeclared-field-write-driver-split注释(Q2-B 裁定长期保留);plugin-auth/src/auth-contains-filter.test.ts及其 devDep(归 finding 单 [finding] #5704 收口后仓内新增一个 driver-memory 测试消费者:plugin-auth/auth-contains-filter.test.ts(#5710 pin 测试,与 #5704 程序不变量的张力,请分诊裁处置) #5830);验证(全部前台阻塞执行,真实输出)
依赖闭包在新 worktree 内先
pnpm --filter '...^...' build建过再跑测试;重活全程走共享flock /tmp/os-heavy-verify.lock串行 +--max-old-space-size=4096。Changeset
测试/依赖清理,不面向用户 → 无 changeset,
skip-changeset(label 由 PM 代打)。🤖 Generated with Claude Code
https://claude.ai/code/session_01WyvqvKMG6asi9aXjKE6xtx
Generated by Claude Code