Repository navigation
docs(data): name currencyConfig.homeAmount on field-types, validation-rules and objectql schema pages - #28374
Merged
Conversation
…-rules and objectql schema pages Each page now lists all four currencyConfig keys, with homeAmount pointing at currency.mdx's 'Declaring the home amount' section for its shape (field, rateDate as date/datetime, rateField as number). Claude-Session: https://claude.ai/code/session_01QUs3BtCUdWfucAb3edvUF2 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
domain:devx#1 · os-zhuang · session_01QUs3BvP5Aq9USg5GtmgAAR 席位核对 — ACCEPT ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sam · project thread
Fixes #28330
Clause-②: no
Metadata-protocol: none
维护者速读
currencyConfig说明补上第四个键homeAmount。homeAmount已随 spec 发布、currency.mdx也已重写,这三页仍只列三个旧键,读者不知道有本币折算投影。content/docs/data-modeling/field-types.mdx(新增表格行),validation-rules.mdx(两处),protocol/objectql/schema.mdx(一行)。git grep -n homeAmount -- content/docs/data-modeling/field-types.mdx content/docs/data-modeling/validation-rules.mdx content/docs/protocol/objectql/schema.mdx,预期 4 处命中,均链接currency#declaring-the-home-amount。What changes
Each of the three pages now names all four
CurrencyConfigSchemakeys (currencyMode,defaultCurrency,currencyField,homeAmount), withhomeAmountpointing at the "Declaring the home amount" section ofcurrency.mdxfor its shape:content/docs/data-modeling/field-types.mdx: newcurrencyConfig.homeAmountrow in thecurrencyproperty table.content/docs/data-modeling/validation-rules.mdx: newcurrencyConfig.homeAmountrow in thecurrencytable; the per-type summary row now lists the four keys.content/docs/protocol/objectql/schema.mdx: thecurrencyConfigrow nameshomeAmountbesidecurrencyFieldunderrecord.The wording follows
HomeAmountSchemaand thehomeAmountdescribe inpackages/spec/src/data/field.zod.tsand main'scurrency.mdx:recordmode only and optional there, refused underdynamicandfixed; three required pointers into the same object:field(adynamic-modecurrencyfield,readonly: true),rateDate(adateordatetimefield) andrateField(anumberfield,readonly: true).Tests
Docs only. No package source changes, so no package tests are owed.
Acceptance notes
None.
Verification
dispatch-gates derived set, run at 1e8672f
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 43 commands; all 43 exited 0 (check:skill-examplesfirst refused with exit 3 because@objectstack/client-reactwas unbuilt, then exited 0 after building it). Reconciliation:dispatch-gates --ran: 43 derived famil(ies) accounted for — 43 run, 0 NOT-MEASURED (a DERIVED zero — all 43 recorded an exit code and none of them is 3).Generated by Claude Code