Skip to content

ci(spec-shape-gate): register the retirement of the page component's visibility and the view form's visibleOn #23920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 2 commits into from
Oct 16, 2026
Merged

ci(spec-shape-gate): register the retirement of the page component's visibility and the view form's visibleOn #23920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2aef71
ci(spec-shape-gate): register the retirement of the page component's …
claude Oct 16, 2026
1adf504
ci(spec-shape-gate): register the retired visibility key's test-proje…
claude Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion scripts/ci/spec-shape-retirements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
{
"$comment": "Intentional spec retirements the Spec Shape Gate reads as `known` instead of red. One entry per retirement, written by the accepting seat when the downstream (objectui) card is filed, deleted when that card closes. Every entry carries exactly: retired, objectstack_pr, objectstack_commit (40-hex merge commit), downstream_card (owner/repo#N), registered_at (YYYY-MM-DD), matches (non-empty; each pattern names a repo-relative objectui `file` -- `*` within a segment, `**` across -- plus at least one of `code` (TS<digits>) or `message` (substring)). A file alone is refused. The reader, its grammar and its refusals: scripts/ci/spec-shape-gate.mjs (THE REGISTRY).",
"retirements": []
"retirements": [
{
"retired": "the page component's `visibility` and the view form's `visibleOn` (field and section), retired as keys -- retiredKey() tombstones naming `visibleWhen` (F4 of #23543) -- objectui still passes the page component's `visibility` to an expression argument, and its expressions test (compiled only by the package's chained test project) still authors that key",
"objectstack_pr": 23836,
"objectstack_commit": "105902f10ae8124a5e965cb24f7b30681fd9fae2",
"downstream_card": "objectstack-ai/objectui#12654",
"registered_at": "2026-10-16",
"matches": [
{
"file": "packages/react/src/SchemaRenderer.tsx",
"code": "TS2345",
"message": "Argument of type '{ '[REMOVED] Key retired: run `os validate` for its migration.': never; }' is not assignable to parameter of type 'string | boolean | { dialect?: string | undefined; source?: string | undefined; } | undefined'."
},
{
"file": "packages/react/src/__tests__/SchemaRenderer.expressions.test.tsx",
"code": "TS2322",
"message": "Type 'string' is not assignable to type '{ '[REMOVED] Key retired: run `os validate` for its migration.': never; }'."
}
]
}
]
}
Loading