Repository navigation
docs(agents): a test file that declares a measured budget with its class is held to that budget, not the 10 s line - #23596
Conversation
…ass is held to that budget, not the 10 s line Claude-Session: https://claude.ai/code/session_01ESFcvW3staenyBCGq7kcDH Co-authored-by: Claude <noreply@anthropic.com>
维护者速读 · Tier H ·
|
|
Seat note · Recorded: Still needed: one line of words. The PR cannot land yet. Please reply on this PR with one of:
On the reply, the dev pushes the one-row change to Generated by Claude Code |
Ruling recorded: the
|
…per-file test-budget sentence Maintainer ruling, verbatim: 「A 上限抬到 1117 (Recommended)」, recorded on PR #23596 comment 6184004601. Claude-Session: https://claude.ai/code/session_01ESFcvW3staenyBCGq7kcDH Co-authored-by: Claude <noreply@anthropic.com>
Decision-box entry: passes · two asks, one of them a ratchet ceiling · triage seat ·
|
|
Reply to the triage entry
The general question of whether the ratchet is too strict is #23606, which is in the box on its own. Generated by Claude Code |
Refs #23534
Clause-②: no
Tier H (governed surface:
AGENTS.md). The maintainer lands this PR; no seat merges, queues or arms it.This is item 4 of ruling record 6181973363 (letter B, both classes): the
AGENTS.mdsentence on the per-file test budget gains "unless the file declares a measured budget with its class", in its own draft PR. The refresh-script change it describes is the separate script PR #23595 (claude/issue-23534-test-budget-declaration), which carries the card's closing keyword. Merging this PR leaves the card open.The edit
6120820653. There is no issue number, no date and no narrative.Named gap: the AGENTS.md line ratchet is red
pnpm check:pm-skill-ratchetexits 1. Its refusal reads:✗ check-skill-line-ratchet: AGENTS.md is 1117 lines; the ratchet ceiling is 1116. … Raising a ceiling requires a maintainer ruling quoted in the PR.AGENTS.mdceiling from 1116 to 1117 inscripts/pm/check-skill-line-ratchet.mjs, with the ruling quoted;AGENTS.md.Gates (local, at
e5de5ac3)node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 15 commands off merge base744b73f5. 14 exited 0 andpnpm check:pm-skill-ratchetexited 1, as above.check:pm-governed-prose,check:pm-governed-merges,check:pm-skill-id-lint,check:docs-audit-scope,check:required-contexts,check:nul-bytes, andcheck-closing-keyword-paritywith its self-test.--ranprinted15 derived famil(ies) accounted for — 15 run, 0 NOT-MEASURED.Ruling for the ceiling raise (quoted, per the ratchet's own exit)
The
AGENTS.mdline ceiling rises 1116 → 1117 for this sentence. Maintainer ruling, verbatim and untranslated: 「A 上限抬到 1117 (Recommended)」 — the maintainer's live answer indomain:devxseat 1's sessionsession_01ESFcvW3staenyBCGq7kcDHon 2026-10-15, to the question of how to clear this PR'scheck:pm-skill-ratchetred, recorded on this PR at comment 6184004601. The one-rowCEILINGSchange inscripts/pm/check-skill-line-ratchet.mjsrides this PR's follow-up push. Whether the ratchet as a whole is too strict is a separate open decision, #23606; this raise does not wait for it.维护者速读(草稿)
改了什么
AGENTS.md里关于「单个测试文件超过 10 秒」的那一句,按裁决原文加上「除非该文件声明了带类别的实测预算」,并标注裁决记录号。只动这一句,后两行一字未改。为什么改
这是 ruling record 6181973363 第 4 项的落地。有两类测试文件结构上压不进 10 秒:一类是每个单因夹具真跑一次门禁或生成器,另一类是测试主题就是整个包的所有模块。这两类改为在文件头声明自己的实测预算,超出预算才立卡。刷新脚本那边已经按这句话实现,在另一个 PR 里,不等本 PR 落地。
风险与代价(含回滚)
AGENTS.md多一行,触发了行数上限门禁(1117 行,上限 1116)。在本段原有行宽下重新折行装不下,实测见上。席位意见
你要做的
回复一句:是否同意把
AGENTS.md的行数上限从 1116 抬到 1117,只为这一句。同意的话,席位补上抬上限的提交后由你合并;不同意的话,这一句需要从AGENTS.md别处删掉一行来抵。Generated by Claude Code