Repository navigation
test(dogfood): the two view resets drop the ?package= the reset door never read - #23105
Merged
objectstack-fleet[bot] merged 1 commit intoOct 12, 2026
Merged
Conversation
…never read
The DELETE {metaPath}/:type/:name door (the reset) reads only `state`,
`dropStorage` and the bundle member selector; `DeleteMetaItemRequest`
declares no package. Its closed query set (route rule 5) now answers a
located 400 for any other name, so the two dogfood resets that still
carried `?package=` went red on the full battery. Dropping the parameter
changes nothing the handler does: it was ignored before the closed set
landed. The PUT saves keep their `?package=`, which that door reads.
Claude-Session: https://claude.ai/code/session_01VoSxBQujKLZKPwK2u5ehQ6
Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
objectstack-fleet
Bot
deleted the
claude/issue-23084-dogfood-reset-package-param
branch
October 12, 2026 23:22
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23084
Clause-②: no
What changes
packages/qa/dogfood/test/view-container-cross-package-default.dogfood.test.ts, two lines: the two view resets drop the?package=${REPAIR}the reset door never read.:174DELETE /meta/view/os_qa_shadow_probe?package=${REPAIR}becomesDELETE /meta/view/os_qa_shadow_probe:228DELETE /meta/view/os_qa_keyed_probe?package=${REPAIR}becomesDELETE /meta/view/os_qa_keyed_probeNothing else moves. The two
PUTsaves (:149,:203) keep their?package=, because the save door reads it. The closed query set inpackages/rest/src/rest-server.tsis not widened. No changeset:@objectstack/dogfoodis private and publishes nothing.Why (triage ruling 6131531682, applied as ruled)
Dogfood Regression Gate (1/3)since038d4c9588(PR feat(metadata-protocol): one language of an email template is addressed by name — the by-name /meta doors accept a bundle member selector (#22877, stage 2) #23070). That PR gaveDELETE {metaPath}/:type/:nameits closed query set,META_ITEM_RESET_PARAMS = ['state', 'dropStorage', member](rest-server.ts:744, refused at:7346), as route rule 5 asks.packageis not in it, so these two test calls now get a correct located 400.package. On2d21b9c891the handler's only query reads arestate(:7348),dropStorage(:7357) and the member selector (:7386). The four helpers it calls (resolveExecCtx,walledCatalogRefusal,resolveProtocol,resolveMetaWriteActor) read noreq.queryat all.DeleteMetaItemRequestdeclares no package (protocol.lock-one-resolution.test.ts:607-608says so). The pre-feat(metadata-protocol): one language of an email template is addressed by name — the by-name /meta doors accept a bundle member selector (#22877, stage 2) #23070 handler (038d4c9588^) read the same two names,stateanddropStorage, and nothing else. So dropping the parameter changes no behaviour, because the handler already ignored it.git grepon2d21b9c891: these two test lines are the only places that put?package=on a metaDELETE.Measured
All runs are in this container, on base
2d21b9c891plus the fixa61ad11dd3, throughscripts/pm/os-verify-lock.sh. The dogfood dependency closure was built first (pnpm turbo run build --filter=@objectstack/dogfood, 63/63 tasks).2d21b9c891):Tests 2 failed | 2 passed (4). Both failures areAssertionError: expected 400 to be 200, at:175:28(steps 1-7) and:229:28(keyed member). This matches the hourly run.a61ad11dd3): the same file givesTest Files 1 passed (1),Tests 4 passed (4), and the lock reportsVERDICT command-exit 0.OS_TEST_SHARD=1/3 pnpm --filter @objectstack/dogfood exec vitest run --maxWorkers=2, CI's own carrier, ata61ad11dd3):Test Files 87 passed (87),Tests 718 passed (718), and the lock reportsVERDICT command-exit 0.BaseSequencer.shardslice (sha1 of the root-relative path,[0, 87)of 259), recomputed locally. That slice contains this file.pnpm --filter @objectstack/dogfood run typecheckexits 0.tsc --listFilescounts the edited file once, so the program does cover it.dispatch-gates --commandslists 53 commands, the same list on2d21b9c891, ona61ad11dd3with no paths, and on currentorigin/mainabf86554c9. All 53 exit 0 ata61ad11dd3.check:dual-build-cjs-loadsfirst exited 3 (PREREQUISITE NOT MET, 8 packages unbuilt). It exited 0 once those were built:107 published require entry point(s) across 66 package(s) load.--ranreconciliation:53 derived famil(ies) accounted for.isPathIgnored: false, with 5 rules enabled for the file.--format json: 1 file, 0 errors, 0 warnings, exit 0.parserOptions.projectorprojectService, and the 5 rules are per-file AST rules. So this diff cannot move any other file's verdict.For #23072: the PUT door does read
packagePUT {metaPath}/:type/:namereadspackageatrest-server.ts:7175(metaItemPackageBinding(req.query?.package)) and threads it aspackageIdinto the save request (:7225).The handler's other query reads:
force(:7166);mode, read a frame down inmetaSaveRequestOptions(:7146,meta-save-request.ts:94);['force', 'package', 'mode'](:7145).The PUT declares no closed set yet. The test's
PUT ...?package=${REPAIR}at:203carries weight::222asserts_packageIdisREPAIR. This line is not changed here.Acceptance notes
origin/main: it moved 4 commits during this run (abf86554c9: lint, metadata-protocol, objectql, CI timing scripts). This diff is two test lines and dogfood runs only in the full battery, so the pin is the next hourly full run onmain:Dogfood Regression Gate (1/3)green.Test Core (6/6)red isshard-timing-driftand is not this card, as the claim notes.Generated by Claude Code