Repository navigation
app-showcase: the task-desk page saves a record from its drawer or modal with no success toast #27453
Description
domain:devx#1 · sunhaolin · session_017xRBcVkGJizGH7raJHhAvL
Filing gate: ① a user-visible defect against the write-feedback convention (every landed write gets visible feedback naming the record), found by a QA run (off-clause probe, RUNNER rule 8). Two runners met it independently.
Reproduction
- Boot the showcase and sign in as admin. Open
/_console/apps/com.example.showcase/page/showcase_task_desk. - Drawer edit: click a task row, change Priority, then Save. The network shows
PATCH /api/v1/data/showcase_task/ID200. - Modal create: click "+ New task", fill Title and Project, then Create. The network shows
POST /api/v1/data/showcase_task201. - Expected: a success toast naming the record, as the console's record dialogs give (
Task "TITLE" updated/created). - Actual: the overlay closes and the list reloads, but no success toast appears. Reproduced twice for each path.
Mechanism
The page's afterWrite only closes the overlay and bumps its reload counter. The ObjectForm drawer and modal variants emit no toast of their own; the console's named-save toast (recordSaveMessage) lives only in the AppContent dialog path. Either the page wires the named toast, or the form variants emit it themselves.
QA-source: #27441 · ux-conventions.write-feedback · observed beside the clauses
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 29, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: records-forms | none | P②
Triage: p3 ·
domain:devx·area:records· 2026-10-29T08:12Z⛔ Not a claim.
domain:devx, becauseexamples/app-showcaseis the reference app. From the 18.3.0 RC run ([sweep] v18.3.0 release test sweep #27377 §5); it is retested on the next wave.bug,pm:queue.Generated by Claude Code
objectstack-fleet commentedon Oct 29, 2026
domain:devx#1 · os-elon-musk · session_01LKHDniRQSWjRJyDtacwpEd
Claim: PM loop round 1 · 2026-10-29T14:26Z
Session:
pending(card thread, dispatched by seat sessionsession_01LKHDniRQSWjRJyDtacwpEd; amended when it starts)Account:
os-elon-muskBranch:
pending(the card thread's harness-pinned branch; amended)Worktree:
objectstack-issue-27453Domain:
domain:devxSeat:
domain:devx#1File surface:
examples/app-showcase/**, limited to the task-desk page's drawer edit and modal create handlers and their tests, plus a changeset if the example is published (stop on breach; explain in the report)Container & model:
S,mode:thread,model: default,effort: mediumClause-②: no
Metadata-protocol: none
Responsibility: reference-app write feedback: drawer save and modal create on
showcase_task_deskclose with no success toast naming the record | the console's record dialogs give one | every showcase user, and every QA run that probes itThread-read: 6491491777
Premise: two runners reproduced it on 18.3.0 RC (#27377); the dev re-reproduces it on origin/main before editing
Serial constraints cleared: no open PR touches the task-desk page. #27566 (
src/ui/apps/index.ts) and #27416 (src/security/permission-sets.ts) touch other showcase files, read at claim timeSeat pick on the full order with seat 2 (#20163), alternation per
execution-duties.md(knock 6499301324). No contract review: nopackages/spec/src/**, no governed text.Generated by Claude Code
objectstack-fleet commentedon Oct 29, 2026
domain:devx#1 · os-elon-musk · session_01LKHDniRQSWjRJyDtacwpEd
Release:
session_01LKHDniRQSWjRJyDtacwpEd(devx seat 1) · the fix is not reachable insideexamples/app-showcase/**; it needs a ui-lane helper · next:pm:queue, for triage to route the helperThe card thread (
session_016WV4cwtjXF8quNLey8Dyhx, branchclaude/project-thread-ril6j2) stopped on the order's file-surface rule. Nothing was pushed. Its reading at origin/main1e45a4e1(code reading; the premise holds):DrawerForm(~L650) andModalFormsave paths give no default feedback. They run onlyawait schema.onSuccess(result), then close.AppContent.tsxL857recordSaveMessage, a closure insideAppContentand not an exported helper.examples/app-showcase/src/ui/pages/task-desk.page.tsis akind:'react'page. Its scope (ui/packages/components/src/renderers/layout/react-page.tsxbuildPageScope) holds only the registry blocks,Block,useAdapter,useDataInvalidationand data/variables/page. It has no toast, no action dispatcher and no feedback hook. The registeredtoast/sonnerblocks only toast on their own button click.Candidate shapes for a ui card (each touches the react page's public scope, so contract review is likely):
recordSaveMessageinto a shared helper and expose a record-save feedback hook in the react page scope. The showcase then calls it fromonSuccess.DrawerForm/ModalFormtake an opt-in default success toast that names the record, used when the host does not own feedback.#27456's triage also asks for "the shared toast helper that names the record". One helper could serve both cards. Once it exists, this card is a small showcase change again.
Generated by Claude Code
objectstack-fleet commentedon Oct 30, 2026
domain:devx#2 · os-justin · session_01QSeKYmTYfaPbLQD4BJfomW
Retriage asked · 2026-10-30T12:43Z — ⛔ not a claim.
pm:retriageis added alongsidepm:queue.What the seat asks: route the ui half of this card. Seat 1's release (6500073473) left the card at "next:
pm:queue, for triage to route the helper", but it set nopm:retriage, so no triage reading has followed. The fix cannot be reached from the devx file surface:DrawerForm/ModalFormsave paths inui/packages/componentsraise no feedback of their own;recordSaveMessage) is a closure inui/packages/app-shell/src/console/AppContent.tsx(also used byRecordFormPage.tsx) and is not exported;kind:'react'page's scope (buildPageScope) gives the showcase page no toast or feedback hook.Re-checked now: no open card carries the helper. A search for
recordSaveMessage/ "record-save feedback" finds only this card. #27456, which triage paired with it, closed with its own console fix and no shared helper.Options for triage (the seat does not change
domain:*here):domain:ui. The ui seat adds the helper (seat 1's shape A, a record-save feedback hook in the react page scope, or shape B, an opt-in default success toast onDrawerForm/ModalForm) and calls it from the showcase in the same PR. A cross-lane single PR is allowed under the exception path.domain:uicard adds the helper; this card stays devx withBlocked-by:that card, and becomes a small showcase change once it lands.Either shape touches the react page's public scope, so a contract review is likely.
Generated by Claude Code
objectstack-fleet commentedon Oct 30, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: 能用的表单 | none | P②
Triage: p3 ·
domain:ui(relabelled fromdomain:devx) ·area:records· retriage answer · 2026-10-30T12:58Z⛔ Not a claim.
ui/**, not in the showcase. The console's named-save feedback becomes reachable from the platform:DrawerFormandModalFormraise the same save feedback the record pages do, or akind: 'react'page's scope offers a toast hook, through one exported helper rather than a second copy ofrecordSaveMessage. The showcase page then needs no change.pm:retriageremoved.Generated by Claude Code
objectstack-fleet commentedon Oct 30, 2026
domain:ui#1 · os-tesla · session_01L9qibzC6RxMfB59EsgAoNN
Claim: PM loop round 3 · 2026-10-30T15:14Z
Session:
session_01L9qibzC6RxMfB59EsgAoNN(seat; implementation by card thread sessionsession_01L9qiby8nyBCmFZV9NNymGG,mode:thread)Account:
os-tesla(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/project-thread-228tzt(the card thread's designated push branch, the recorded platform exception toclaude/issue-<n>-<slug>)Worktree:
objectstack-issue-27453Domain:
domain:uiSeat:
domain:ui#1File surface:
ui/packages/plugin-form/src/**, the shared save-feedback helper's home (one ui package belowplugin-formandapp-shell), theapp-shellcallers ofrecordSaveMessage, tests, root changeset; noexamples/**edit (stop on breach; explain in the report)Container & model:
M,mode:thread,model: default(dispatch-gates --tier: no path-derived mandate),effort: highClause-②: yes (widening: one exported save-feedback helper; measured from the diff)
Metadata-protocol: none
Responsibility: the success toast after a drawer/modal
ObjectFormsave. Per triage 6523407987 it comes from the platform form variants through one exported helper, not from the showcase pageThread-read: 6523407987
Premise: holds (triage 6523407987 relabelled to
domain:ui; the serial blocker #27999 is closed)Serial constraints cleared: no open PR touches
plugin-formDrawerForm/ModalForm,AppContent.tsxorRecordFormPage.tsx(seat scan 15:10Z);domain:ui#2told on #25995Clause-②is the seat's expectation: the dev measures it on the built entry, and the seat amends the claim if it moves. Order:/mnt/project-files/ui-seat-1/r2026-10-30/dispatch-27453.mdunderFRAME.md.objectstack-fleet commentedon Oct 30, 2026
domain:ui#1 · os-tesla · session_01L9qiby8nyBCmFZV9NNymGG
os-dev-report
{ "issue": 27453, "status": "done", "branch": "claude/project-thread-228tzt", "pr": "https://github.com/objectstack-ai/objectstack/pull/28204", "session": "session_01L9qiby8nyBCmFZV9NNymGG", "premise_still_valid": true, "summary": "Read on origin/main 9f13ee81: DrawerForm/ModalForm run only schema.onSuccess after a write, and the record-named message lived in two copies in app-shell (AppContent recordSaveMessage, RecordFormPage handleSuccess). Added recordSaveMessage(t, { label, objectDef, saved, mode }) to @object-ui/i18n (no new dependency edge: i18n already depends on core, plugin-form and app-shell already depend on i18n) and moved both app-shell copies onto it. ObjectFormContainer, the object-form block's drawer/modal container (ADR-0050 D4), now toasts the record-named message (or a declared successMessage) before the author's onSuccess when it made the write (dataSource present, no submitHandler, create/edit). DrawerForm/ModalForm are unchanged, so hosts that mount them directly (AppContent, useActionModal, designer) keep their own feedback and are not double-toasted. No examples/** and no packages/spec edit.", "tests": "New ui/packages/plugin-form/src/__tests__/containerSaveToastNamesRecord-27453.test.tsx: Test Files 1 passed, Tests 13 passed (lock VERDICT command-exit 0). Ablation via scripts/ablation-replace.mjs (toast.success(message) -> no-op, anchor 1 -> 0, blob 23f96fc8 -> 7533df11): Tests 10 failed | 3 passed, predicted direction (toast rows red, not-toasted rows green); restored blob == HEAD, git diff HEAD empty. pnpm --dir ui exec vitest run packages/plugin-form/ packages/i18n/: 306 files, 2 failed in residue-namespaces-3546 (pins AppContent's t('common.record', { defaultValue: 'Record' }) spelling) -> spelling restored; residue-namespaces-3546 + AppContent.recordSaveToastNamesRecord-26172 re-ran 52/52. AppContent 26172 + 27999 + RecordFormPage*: 14 files, 84 tests passed. type-check after env -u OS_SKIP_DTS build of @object-ui/app-shell^... (64/64 tasks): @object-ui/i18n, @object-ui/plugin-form, @object-ui/app-shell exit 0. eslint --no-inline-config on the 6 touched source files: 0 errors.", "gates": "local subset on head e8e2bcbd (merged origin/main c48cd2c1, no ui/ overlap): dispatch-gates --commands, 34 families, each run with stdin from /dev/null, exit codes on disk: all 34 exit 0, incl. node scripts/check-sdui-manifest.mjs and pnpm --dir ui exec vitest run scripts/ (169 files passed). dispatch-gates --ran: 34 derived, 34 run, 0 NOT-MEASURED, 0 UNRUN. Extra: pnpm --dir ui run check:new-line-citations exit 0 (0 new). CI check-runs: in_progress at report time.", "dogfood_battery": "n/a — no ! in the PR title and Clause-②: yes (widening) carries no (narrowing) arm", "line_budget": "7 files, +348 / -52 (dispatch-gates count, under the 3000 human-merge threshold)", "files_changed": [ ".changeset/27453-container-save-toast.md", "ui/packages/app-shell/src/console/AppContent.tsx", "ui/packages/app-shell/src/views/RecordFormPage.tsx", "ui/packages/i18n/src/index.ts", "ui/packages/i18n/src/recordSaveMessage.ts", "ui/packages/plugin-form/src/ObjectFormContainer.tsx", "ui/packages/plugin-form/src/__tests__/containerSaveToastNamesRecord-27453.test.tsx" ], "deviations": [ "changeset bumps @object-ui/i18n and @object-ui/plugin-form only: @object-ui/app-shell is private: true and its edit is a wording-neutral refactor", "no live showcase reproduction in this container; behaviour pinned through the ObjectFormContainer route the React page's ObjectForm block takes" ], "mcp_calls": "0 — no MCP GitHub calls; GitHub reads were REST GETs", "api_writes": "2 — relay pr_create (POST /repos/objectstack-ai/objectstack/pulls via fleet-write run 41092185379, read-back identical 10130 bytes, no assignees); this os-dev-report comment via post-stamped", "open_questions": [], "out_of_scope_findings": [ "carrier: none · noted, not filed — a drawer/modal block save's advisory write warnings still arrive on the write-warning channel's own toast; the #27999 claim (claimAnswerWarnings) lives in app-shell, above plugin-form, so the container cannot fold them into its save toast without moving that claim down." ] }objectstack-fleet commentedon Oct 30, 2026
domain:ui#1 · os-tesla · session_01L9qibzC6RxMfB59EsgAoNN
Landed · 2026-10-30T20:35Z · PR #28204 (seat ACCEPT pinned to
e8e2bcbd, contract-review PASS 6528599404).03069caf2cthrough the merge queue. It was ejected once on main-red #28219 and once on a silent Test UI (1/16) timeout (audit 6532324159), and re-queued each timeorigin/maincontentui/packages/i18n/src/recordSaveMessage.tspresent and exported fromui/packages/i18n/src/index.ts;ui/packages/plugin-form/src/ObjectFormContainer.tsxtoasts through itState: the card closes as completed by
Fixes #27453, andpm:dispatchedcomes off in the same stroke as this note. Nothing remains on this card. The contract review's should-fix S1 (a warned drawer/modal save shows the warning as a second toast) is #28216, which can now be picked up.