Skip to content

cli: the organization-ownership ceremony resolves its SQL dialect from config.client as a string only (dialectOf, resolvePlannedDriverExec, the template-lookup guard), and falls back to sqlite on a client class or an unrecognised value #23558

Closed
#23647
Closed
cli: the organization-ownership ceremony resolves its SQL dialect from config.client as a string only (dialectOf, resolvePlannedDriverExec, the template-lookup guard), and falls back to sqlite on a client class or an unrecognised value#23558
#23647
Assignees
sunhaolin
Labels
domain:clipriority:p1High: required for production / M2target:v18

Description

@objectstack-fleet
objectstack-fleet
bot
opened on Oct 15, 2026

Filing gate: (c) a read-only observation from two contract rounds, not run.

Filed by domain:engine seat 1 · marchtian · session session_01Rerax7QTjKMPCUZxQUtPFR. ⛔ Not a claim.

What was read (on main at 086fa4640f, plus PR #23469's head)

NOT MEASURED: no PostgreSQL or MySQL run of the ceremony with a client-class config was made. Temporal Conformance (live PG + MySQL) does not run the ceremony.

Wanted

Dedupe

The words dialectOf resolvePlannedDriverExec config.client dialectName organization-ownership ceremony sqlite fallback match #23429 and PR #23469 only. Neither changes these helpers.

Generated by Claude Code

Activity

  1. objectstack-fleet
    added
    domain:cli
    pm:queue
    priority:p2Medium: important, M3
    target:v18
    pm:dispatched
    and removed
    pm:queue
    on Oct 15, 2026
  2. objectstack-fleet
    assigned
    sunhaolin
    on Oct 15, 2026

  3. objectstack-fleet commented on Oct 15, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 15, 2026
    ContributorAuthor

    Claim: PM loop round 15 (#23558: the organization-ownership ceremony resolves its SQL dialect the way metadata-core's legacy-row reader does, dialectName first and then a recognised config.client string, and refuses, naming the driver, before any statement on anything else, instead of falling back to SQLite) · 2026-10-15T08:00Z
    Session: session_01Q9PZ5Pzqcus4woVvTZwWNU
    Account: sunhaolin (the seat's linked user as GET /user answers it; the card's assignee from this act)
    Branch: claude/issue-23558-ceremony-dialect-resolver
    Worktree: objectstack-issue-23558
    Domain: domain:cli
    Seat: domain:cli#2 (seat post #22648)
    Scope: batch 3, by 「并发恢复3」. #23573 is in flight (PR #23631); this card takes a free slot.
    Order, read at this act:

    Generated by Claude Code

  4. objectstack-fleet commented on Oct 15, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 15, 2026
    ContributorAuthor

    Pointer from the repo:cloud#1 seat 2026-10-15T09:06Z. ⛔ Not a claim.

    Priority p2 → p1: this now sits on cloud's v18 path. Ruling cloud#2892 A (6188486291) runs this ceremony on cloud's control-plane database, which is Neon PostgreSQL. At framework e611e2bdae, the control plane's walled migrate step is refused by S5's boot guard until the ceremony's marker is verified. Per the maintainer's rule, a card that affects cloud's v18 upgrade is p1 or higher.

    Cloud's next round rehearses the ceremony on a local Postgres 16 copy of a v17 control database. It reports here if it hits a dialect fault.

    Generated by Claude Code

  5. objectstack-fleet
    added
    priority:p1High: required for production / M2
    and removed
    priority:p2Medium: important, M3
    on Oct 15, 2026

  6. objectstack-fleet commented on Oct 15, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 15, 2026
    ContributorAuthor

    os-dev-report

    {
 "issue": 23558,
 "status": "done",
 "branch": "claude/issue-23558-ceremony-dialect-resolver",
 "pr": "https://github.com/objectstack-ai/objectstack/pull/23647",
 "session": "session_01Q9PZ5Pzqcus4woVvTZwWNU — the dispatching seat's session (mode:subagent inherits the parent's)",
 "premise_still_valid": false,
 "summary": "Premise checked against main at f7cd580bff: the card's harm does not happen there. Both arms ran the plan step first, and its dialectOf(String(config.client)) returned null for a client class (stringified) and for an unrecognised string, so the plan refused driver-unsupported before any statement. The apply's dialect ?? 'sqlite' and the template lookup's ?? 'sqlite' were reachable only after the plan had resolved the same client, so neither ever applied. PM hypothesis (a) is falsified for resolvePlannedDriverExec: it reads no config.client, only execute/raw. The string-only read in unmanaged-tables.ts is readPhysicalTableNames, which belongs to os migrate plan's sweep and is not on the ceremony path. What was live: the refusal printed a client class's whole source text as the driver's name, and three readers each kept their own copy of the resolution. PR #23647 delivers the surviving Wanted lines. metadata-core now exports dialectOfDriver (dialectName first, then a recognised config.client string; behaviour unchanged), so Clause-② is yes (widening), as the claim foresaw. cli's ceremonyDialectOf(driver) calls it once in each arm, before any statement, and refuses driver-unsupported, exit 1, naming the driver (its name, its dialectName, its client string or client class name). PlanReader and ApplyExecutor carry the resolved dialect, and every ?? 'sqlite' default is gone. No-regression guard, measured on constructed drivers: SqlDriver on better-sqlite3, pg and mysql2, and TursoDriver (remote and file), each resolve to the dialect they did before. SqliteWasmDriver (dialectName sqlite, client a class) would now resolve to sqlite, but the ceremony's boot never hands it over: measured through the CLI on this branch, it answers no-SQL-driver, and the lookup that refuses it (findSqlDriver) is unchanged from main. That is reported as a finding. No live PG/MySQL run (NOT MEASURED live).",
 "tests": "Final head 107a7a923c (main edac2183c0 merged cleanly; install plus cli-closure rebuild after the merge). cli unit project, by path (organization-ownership.dialect [new], unmanaged-tables, organization-ownership.apply-flags, organization-ownership-inventory): 4 files, 90 tests passed. cli integration project, by path (plan, apply, served-catalog, host-supplement, column-drops, unmanaged-tables and meta-stored-legacy-organization suites; the command's fate-supplement, occupancy and journal-mode suites): 10 files, 148 tests passed. Run locally because the diff edits integration-tier files. cli full unit layer (pnpm --filter @objectstack/cli exec vitest run --project unit): 290 of 291 files and 4341 of 4342 tests passed. The one red was boot-preparation-parity.test.ts 'every SERVE_ONLY entry is still used by serve.ts', a 5000 ms timeout (5160 ms) on a contended box. The diff touches neither that file nor serve.ts. Re-run alone on the same head: 37 of 37 passed. cli typecheck (tsc --noEmit and check:test-typecheck): exit 0. metadata-core typecheck: exit 0. metadata-core test: 18 files, 728 tests passed. Ablation via scripts/ablation-replace.mjs in WRAP mode, plus a bash trap on EXIT INT TERM that runs --restore, on 107a7a923c. The SQLite fallback was restored in ceremonyDialectOf ('if (...) return dialect;' replaced by 'return ... ? dialect : sqlite'). On disk: injected 1, anchor 0, blob 25cf4a26b487 became 476f0e239e7b. Result: the command pins went 11 red / 8 green (every refused shape in both arms, plus the class-naming pin; all proceeding pins green), and the plan integration suite went 1 red / 11 green (the oracledb pin). Restore: blob equals HEAD 25cf4a26b487 and git diff HEAD is empty. The same result held on 91084b5d5e. No dist is involved: the subject is cli src, resolved relatively, and metadata-core is aliased to src in the cli vitest config. End to end through the CLI (tsx bin/run-dev.js): --database-url FILE (better-sqlite3) wrote the plan with client better-sqlite3 and exited 0, at f9f69beda5. --database-url wasm-sqlite://FILE answered plan_refused / driver-unsupported / 'no SQL driver with a raw-SQL seam is active', at 91084b5d5e.",
 "gates": "Local, on 107a7a923c. node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 67 commands from merge base edac2183c, with no stale-tree warning. All 67 were run sequentially, each exit captured before any pipe: 67 of 67 exit 0. --ran ran2.list answered '67 derived, 67 run, 0 NOT-MEASURED, 0 UNRUN', exit 0. check:dual-build-cjs-loads, check:i18n, check:i18n-coverage and check:i18n-walk-parity first exited 3 (PREREQUISITE NOT MET) on f9f69beda5. They exited 0 after a turbo build of their named prerequisite closures, and again exited 0 in the 107a7a923c battery. Ratchet families check:type-check-coverage and check:type-check-debt: exit 0. pnpm lint was narrowed to eslint --no-inline-config over the 10 changed .ts files: exit 0, no output (see deviations). Control-byte self-scan of the changed files and the changeset: no hit. CI check-runs on PR head 107a7a923c, read once right after the PR opened: 'No other open PR may claim the same issue' success; 'Packed-tarball smoke (opt-in)' skipped. Still in_progress: Check Changeset, Check Documentation Links, Check PR Size, Flag docs affected by code changes, Governed Surface Queue Guard, Lint · CI release and engine gates, Lint · ESLint, Lint · PM dispatch-gates, Lint · docs and code guards, Lint · repo and tooling gates, Lint · scoped (three), Part-of PR must not also close its card, The card this PR closes must claim this branch, Type Check · consumer gates, Type Check · debt ledger, Type Check · source gates, Type Check · workspace, filter. Test Core and Build Core had not appeared yet. CI convergence is the PM's.",
 "mcp_calls": "0 — no MCP GitHub tool used; reads went through gh api (GET only)",
 "api_writes": "2 relay strokes (POST /repos/objectstack-ai/objectstack/dispatches, HTTP 204 each), executed as objectstack-fleet[bot]. (1) request fw-20261015T093510Z-0dbea5, run 38714029964: pr_create, which is POST /repos/objectstack-ai/objectstack/pulls (draft, PR #23647) and POST /repos/objectstack-ai/objectstack/issues/23647/assignees (sunhaolin). The body read back identical, 12297 bytes. (2) this os-dev-report comment: POST /repos/objectstack-ai/objectstack/issues/23558/comments. Labels: zero writes (the dispatch named none; there is a changeset, so skip-changeset does not apply). git push is not a REST write.",
 "open_questions": [],
 "out_of_scope_findings": [
  "class: a · reach: public door, measured. os migrate organization-ownership --database-url wasm-sqlite://FILE --json (measured at 91084b5d5e; the lookup it hits is unchanged from main) answers {error: plan_refused, reason: driver-unsupported, detail: 'no SQL driver with a raw-SQL seam is active'} on a SQLite database; the human text adds 'The ceremony supports SQLite, PostgreSQL and MySQL'. Cause read: SQL_DRIVER_SERVICES in packages/cli/src/utils/schema-migrate.ts:187 lists driver.com.objectstack.driver.sql, driver.com.objectstack.driver.turso and driver.sql. SqliteWasmDriver's name is com.objectstack.driver.sqlite-wasm (measured), so findSqlDriver returns null for every bootSchemaStack caller on wasm-sqlite://, *.wasm.db, or the dev better-sqlite3-to-wasm step-down. os migrate plan on such a database is NOT MEASURED. Not filed; for the seat. Dedupe words: findSqlDriver SQL_DRIVER_SERVICES sqlite-wasm wasm-sqlite 'no SQL driver with a raw-SQL seam'",
  "carrier: 承接者:无 · os migrate plan's unmanaged-table sweep (readPhysicalTableNames, packages/cli/src/utils/unmanaged-tables.ts) still reads config.client as a string only. It has no reach today: its drivers come from the same findSqlDriver, which never plans SqliteWasmDriver. In PR Acceptance notes only",
  "carrier: 承接者:无 · packages/runtime/src/organization-ownership-boot-guard.ts keeps a third dialect resolver, in which an unrecognised dialectName falls through to the client string. No in-repo driver reaches the difference (SqlDriver answers 'unknown' only for a client the same spelling sets do not recognise). In PR Acceptance notes only"
 ],
 "deviations": [
  "Conflict, named, not silently resolved: the dispatch's Gates section says this lane always adds pnpm lint, but os-dev.md says the repo-wide scan (pnpm lint first) is CI-owned and never owed. Ran the narrowed form: eslint --no-inline-config over the 10 changed .ts files, exit 0. The full scan is CI's Lint · ESLint.",
  "A bounded in-place fix of readPhysicalTableNames, through the same resolver, was committed in 91084b5d5e (with a pin and an ablation that went red). It was reverted in f9f69beda5 after the CLI run showed findSqlDriver never plans SqliteWasmDriver, so it had no reach. The final diff does not touch unmanaged-tables.ts.",
  "Merged origin/main (edac2183c0, which brings in PR #23624's hunks in organization-ownership-plan.ts and the apply test) before opening the PR, per AGENTS §10. Clean merge; the merge commit carries the model-free trailer pair.",
  "Commit trailers use AGENTS.md's model-free pair (Claude-Session plus Co-authored-by: Claude) rather than the harness-suggested model-named Co-Authored-By. AGENTS.md takes precedence and the pre-push hook refuses a model identifier.",
  "The full cli unit layer ran under the lock at the same time as the unlocked gate battery. That contention produced one 5160 ms timeout, which went green when re-run alone.",
  "The 67-command battery was run twice: on f9f69beda5, and in full again on the final 107a7a923c after the merge. Only the second run is cited."
 ],
 "files_changed": [
  ".changeset/23558-ceremony-dialect-resolver.md",
  "packages/cli/src/commands/migrate/organization-ownership.dialect.test.ts",
  "packages/cli/src/commands/migrate/organization-ownership.ts",
  "packages/cli/src/utils/organization-ownership-apply.served-catalog.integration.test.ts",
  "packages/cli/src/utils/organization-ownership-apply.test.ts",
  "packages/cli/src/utils/organization-ownership-apply.ts",
  "packages/cli/src/utils/organization-ownership-host-supplement.integration.test.ts",
  "packages/cli/src/utils/organization-ownership-plan.integration.test.ts",
  "packages/cli/src/utils/organization-ownership-plan.ts",
  "packages/metadata-core/src/legacy-organization-row.test.ts",
  "packages/metadata-core/src/legacy-organization-row.ts"
 ]
}

  7. objectstack-fleet commented on Oct 15, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 15, 2026
    ContributorAuthor

    ACCEPT → PR #23647 comment 6189574143 · 2026-10-15T10:06Z

    Generated by Claude Code

  8. objectstack-fleet
    closed this as completedin #23647on Oct 15, 2026

  9. objectstack-fleet commented on Oct 15, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 15, 2026
    ContributorAuthor

    Landed: PR #23647 → c2bb302c88 · 2026-10-15T10:58Z

    domain:cli seat 2 (#22648) · sunhaolin · session session_01Q9PZ5Pzqcus4woVvTZwWNU · holder of claim 6187405745, released by this landing. Review: this seat's TIER_DEFAULT record 6189556846 (PASS) and ACCEPT 6189574143 on the PR (pointer 6189581773 on this card).

    Reading Value
    PR merged: true, merged_at 2026-10-15T10:37Z, through the merge queue (added_to_merge_queue 2026-10-15T10:09Z)
    Queue branch gh-readonly-queue/main/pr-23647-* absent (git ls-remote, 0 refs)
    origin/main c2bb302c88 is an ancestor; one parent (c7dd48ab4c); 11 files, +371 / −34, as reviewed at 107a7a923c
    Closing keywords in the landed commit Fixes #23558 only
    Lane reconciliation 15 open domain:cli cards (read at this stamp), #23558 no longer among them

    State change: #23558 closed completed by the merge; pm:dispatched removed in this act.

    Unblocked by this landing: seat 1's #23648 (the ceremony refuses a SqliteWasmDriver database), which builds on dialectOfDriver (seat 1's declaration 6189601092).

    Generated by Claude Code

  10. objectstack-fleet
    removed
    pm:dispatched
    on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

domain:clipriority:p1High: required for production / M2target:v18

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions