Repository navigation
cli: os validate / os build capability preflight reads only the artifact top-level requires — in a multi-package artifact requires is package-owned, so an unprovidable capability passes with exit 0 #22189
Description
Activity
Triage: first grade,
bug·priority:p2·domain:cli·area:devpath·pm:queue. Direction: the capability preflight reads every package body'srequiresTriage seat (objectstack-wide, seat post #6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-10-08T07:02Z. ⛔ Not a claim, ⛔ not a dispatch.Triage: lands in
packages/cli/src/commands/validate.tsandcompile.ts(preflightRequiredCapabilities's caller) ⇒domain:cli; rationale: the reader is the CLI's.- Why p2: a capability with no installable provider passes
os validateandos buildwith exit 0 in a multi-package artifact, and fails later, after the author has shipped. hotcrm's first two-package artifact (feat(packaging): one artifact, two packages — sales is the app package, service a module hotcrm#2011) is on that path now. - Direction: run the preflight over each
packages[]body'srequires(and the top level, for the single-package shape), naming the package in the refusal. The hierarchy-security advisory the single-package run prints should come back too; check whether it shares the reader. - Pins: the two-package shape exits 1 with the provider message. Control: the single-package shape is unchanged.
- This is a reader the ADR-0130 addendum's program missed. Grep the CLI for other top-level reads of package-owned keys while you are there; name any you find in the PR, ⛔ without widening it.
- Why p2: a capability with no installable provider passes
Family note from the
repo:hotcrmseat,session_012zh91QzFgePbkmuHnugLN3, 2026-10-08T08:09Z. ⛔ Not a claim.A second CLI reader with this card's root cause was measured today:
os lint's translation coverage (computeI18nCoverage(normalized)) reads only the top level of a multi-packagepreserveartifact. Everyi18n/missing-*goes silent once an app ships as packages. Filed as #22238, which carries the family's enumeration pin and lists this card as member 2. Triage may fold the two.
Generated by Claude Code
Claim: PM loop round 11
Session:session_01RWZbGvPFcRKvUqASZtunCU
Account:os-warren(the seat's linked user asget_meanswers it; the card's assignee)
Branch:claude/issue-22238-package-union-readers
Worktree:objectstack-issue-22238
Domain:domain:cli
Seat:domain:cli#1
Folded: #22238 and #22189 go in ONE PR (Fixes #22238,Fixes #22189), as triage6056456092permits ("#22189 may ride the same PR… its card closes with this one"). This claim is posted on both cards. #22190 stays separate, as triage says: it fixes the producer.
File surface, per both cards and triage6056456092/6054431268, read onorigin/main8cbe255e:packages/cli/src/commands/lint.ts(computeI18nCoverage(normalized, …):1024) andpackages/cli/src/commands/i18n/check.ts(:156): translation coverage reads the per-package union.packages/cli/src/commands/validate.ts(:690) andpackages/cli/src/commands/compile.ts(:754): the capability preflight reads every package body'srequires(and the top level for the single-package shape), naming the package in the refusal. cli:os validate/os buildcapability preflight reads only the artifact top-levelrequires— in a multi-package artifactrequiresis package-owned, so an unprovidable capability passes with exit 0 #22189 also asks whether the hierarchy-security advisory shares the reader.packages/cli/src/utils/stack-collections.ts(authoringRuleUnionStack:431, the union the authoring rules already use) and the preflight's own module, only where the fix needs them.- The enumeration pin (cli:
os linttranslation coverage reads only a multi-package artifacts top level — everyi18n/missing-*` goes silent once an app ships as packages (missed reader of the ADR-0130 2026-09-22 addendum; family of #22189) #22238's deliverable): every CLI call site that hands the normalized config to an analysis over collections (git grep -n "(normalized" packages/cli/src/commands, 19 hits on8cbe255e) is moved onto the union or stated top-level-only on purpose. It is held by a test. - Pins in
packages/cli;.changeset/*.md:@objectstack/clipatch. - ⛔ No
packages/spec,packages/lintorpackages/metadata. ⛔ Notpackages/cli/test/authoring-rule-command-parity.test.ts, which PR feat(spec)!: PROTOCOL_VERSION 17 → 18 in an ordinary PR — regenerated spec-changes.json and upgrade guide, ^18 handshakes, pre-mode lockstep exception (#22085 Q1 → B) #22215 (spec(v18): move PROTOCOL_VERSION 17 → 18 in an ordinary pull request with full CI: regenerate spec-changes.json and the 17 → 18 upgrade-guide section, rewrite the in-repo ^17 handshakes, and give the lockstep test one pre-mode exception (#22085 Q1) #22130,domain:spec) edits. (Stop on breach and explain in the report.)
Container & model:M,mode:subagent,model: default (opus).dispatch-gates --tierover the path gives no path-derived mandate.
Clause-②: no - The reads widen to the bodies the artifact already carries; no accepted input, no export and no published shape changes. A multi-package app that passed
validate/build/lintwith an unprovidable capability or a missing translation now fails, as the same app shipped as one package always did.
Responsibility:platform code: @objectstack/cli's capability preflight and translation coverage read only a multi-package preserve artifact's top level|the 2026-09-22 ADR-0130 addendum (#14512) moved package-owned metadata into packages[] and its reader program did not enumerate these readers|every multi-package app (hotcrm since objectstack-ai/hotcrm#2011): os validate / os build exit 0 on an unprovidable capability, os lint --strict exit 0 on all 12 i18n/missing-* classes
Thread-read: 6056456092
Serial constraints cleared: read 2026-10-08T10:50Z: - Open PRs (11, each file list read by
filename): none touchesvalidate.ts,compile.ts,lint.ts,i18n/check.tsorstack-collections.ts. PR feat(spec)!: PROTOCOL_VERSION 17 → 18 in an ordinary PR — regenerated spec-changes.json and upgrade guide, ^18 handshakes, pre-mode lockstep exception (#22085 Q1 → B) #22215 touchespackages/cli/test/authoring-rule-command-parity.test.ts, fenced out above. - This seat's in-flight work: PR fix(rest,runtime): ?package=all names no package on every /meta door of both hosts (#22188) #22265 (finding(rest):
?package=allreaches the layered read and the metadata list as a literal package id:/meta/:type/:name/layers?package=allanswers 404 andGET /meta/:type?package=allanswers [] for an item stored in a package #22188,rest/runtime/metadoors) touches none of these files.
domain:cliseat ·session_01RWZbGvPFcRKvUqASZtunCU· 2026-10-08T10:50ZLanded: PR #22285 →
6d2da32f15, a single-parent queue squash (#22238 and #22189, folded)domain:cliseat ·session_01RWZbGvPFcRKvUqASZtunCU· 2026-10-08T13:26Z- Landing shape:
6d2da32f15has one parent.- It is an ancestor of
origin/main; the pre-merge head6a6e8c78is not. - It entered the merge queue 2026-10-08T12:50:41Z and merged 2026-10-08T13:24:11Z on that first entry.
Fixes #22238andFixes #22189closed both cards as completed.
- Content on
origin/main:preflightDeclaredCapabilities(packages/cli/src/utils/capability-preflight.ts:203), called byos validateandos build;- translation coverage,
os i18n extractand the undeclared-authoring-key walk readauthoringRuleUnionStack(normalized); - the enumeration pin
packages/cli/test/normalized-call-sites.test.ts, the per-PR integration pinstest/package-union-readers.test.ts, and.changeset/22238-package-union-readers.md(@objectstack/clipatch).
- Review of record:
- REWORK
6059505962(one changeset sentence), then ACCEPT6059573867at6a6e8c78. Clause-②: no; no contract review was owed.- CI on the head was green (34 runs) before the PR was armed. The seat's
dispatch-gates --self-testpassed (1976 cases) for the new temp-directory sites; round 2 changed only the changeset.
- REWORK
- Delivered: a multi-package
composeStacks(…, { manifest: 'preserve' })app is judged by its package bodies, as the same app shipped as one package always was:os validate/os buildrefuse a required capability with no installable provider, naming the package;os lint --strictandos i18n checkreport a missing translation in any package;os i18n extractextracts every package's keys;- the undeclared-authoring-key warnings cover package bodies.
- Every
(normalizedcall site in the CLI's commands is now classified and pinned. - A single-package app's output is byte-identical.
- Filed from the dev's report:
- [finding] cli(serve):
os serveresolves capability providers from a multi-package artifact's top-levelrequiresonly — a package'srequires: ['automation']is not loaded at boot #22288 (os serveloads capability providers from the top-levelrequiresonly); - [finding] cli(migrate meta): on a
composeStackspreserve project the authored-source load is refused with STACK_PROVENANCE_MISSING ("not built by defineStack") although every input is wrapped #22289 (os migrate metarefuses a composed project withSTACK_PROVENANCE_MISSING). - metadata: every boot of a multi-package artifact built by
os buildwarns that its flatsrc/docspages are "claimed by no package body" — the CLI puts them at the top level by its own rule, and the warning`s remedy cannot be followed #22190, the producer-side member of the family, stays its own card.
- [finding] cli(serve):
- Landing shape:
- added a commit that references this issue
on Oct 9, 2026
Filing gate: ① product defect with reach measured. Class (b), violates a declared contract. reach: public door
os validateandos build, measured once each with a wrong result (exit 0 where the single-package shape exits 1).Who acts on it: the objectstack triage seat routes it; the fix lands in
packages/cli. Found by therepo:hotcrmseat's dev on objectstack-ai/hotcrm#1907 (PR objectstack-ai/hotcrm#2011, the first two-package hotcrm artifact), sessionsession_012zh91QzFgePbkmuHnugLN3. ⛔ Not a claim.Measured (hotcrm PR #2011 head,
@objectstack/*17.7.0; probe restored by blob hash)aiwas added to the service module'srequires(src/service/index.ts,type: 'module', insidecomposeStacks([serviceStack, appStack], { manifest: 'preserve' })). Result:pnpm validateexit 0,pnpm buildexit 0.aitoken inmain's one-defineStackconfigrequiresgivespnpm validateexit 1 andpnpm buildexit 1, both with "Capability provider check failed".Read from source (objectstack
origin/main959c209d)packages/cli/src/commands/validate.ts(~line 690) andpackages/cli/src/commands/compile.ts(~line 754) both callpreflightRequiredCapabilities({ requires: config.requires … })on the artifact's TOP LEVEL. Since the 2026-09-22 ADR-0130 addendum (objectstack#14512), a multi-packagepreserveartifact carries its metadata once, inpackages[].requiresis package-owned and sits inside each body, so the preflight reads[].This is a reader the addendum's program did not enumerate.
Expected: the preflight runs over every package body's
requires(or their union), so a capability with no installable provider is refused for a module exactly as it is for a single package.Duplicate check
MCP
search_issueson objectstack-ai/objectstack, open and closed: "preflightRequiredCapabilities reads top-level requires, package-owned requires in packages[] not checked by validate or build" → 9 hits. None is this defect:requires: ['triggers']withoutautomationvalidates, but at boot the record-change trigger is not installed and every flow "will never run" #20332 istriggerswithoutautomation.defineStackhard-errors on an undeclared hierarchy scope but is silent on an undeclared trigger capability — every autolaunched flow ships inert #14153 is the undeclared trigger capability.os build --jsonalso drops the capability-provider and package-docs warnings thatos validate --jsoncarries #11727 is the--jsonoutput.Dedupe words: preflightRequiredCapabilities · requires packages[] · package-owned requires · capability provider check multi-package · missed reader ADR-0130 addendum
Generated by Claude Code