test(flows): native e2e + fix flows route warning found on iOS simulator#72
Merged
Conversation
…evice
Native verification: built and booted the app on an iOS simulator (warm
CocoaPods → xcodebuild). It surfaced a route warning that the web preview
tolerated silently —
WARN No route named "flows" exists in nested children:
[... "flows/index", "flows/[name]/index", "flows/[name]/runs/[runId]"]
After restructuring flows/[name].tsx → flows/[name]/index.tsx (PR #68), the
explicit `<Stack.Screen name="flows" />` no longer matches a route. File-based
routing already registers the flows/* screens (same as `language`), so drop the
stale Screen entry. Confirmed gone after a native relaunch.
Also add a Flows e2e screen test (jest-expo / native preset, not web): renders
the real Flow detail screen and exercises metadata + diagram, the empty run
history, and Run → input dialog → execute with `{ params: {...} }`.
Note: the other e2e suites (auth-flow / app-navigation / record-list) were
already failing on main before this change — out of scope here.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native verification
Built and booted the app on an iOS simulator (iPhone 17, warm CocoaPods → xcodebuild → launched). The app boots and renders natively (server-config screen). This surfaced a route warning the web preview tolerated silently:
After restructuring
flows/[name].tsx → flows/[name]/index.tsx(#68), the explicit<Stack.Screen name="flows" />no longer matches a route. File-based routing already registers theflows/*screens (same aslanguage), so the stale Screen entry is dropped. Confirmed gone after a native relaunch (warning count flat across reload).Also
jest-expo/ native preset, not web): renders the real Flow detail screen and exercises metadata + diagram render, the empty run-history state, and Run → input dialog →executewith{ params: {...} }.Verification
tscclean; unit suite green (1164 passed); new Flows e2e passes.auth-flow/app-navigation/record-list) were already failing on main before this change (13 failures, identical) — pre-existing, out of scope here.🤖 Generated with Claude Code