feat(spec): dashboard widget can bind to a dataset (ADR-0021 B-P1)#1648
Merged
Conversation
…al-form) Additive dual-form for DashboardWidgetSchema: a widget may bind a semantic-layer `dataset` and select `dimensions` + `values` (measure names) by name, instead of the inline `object`+`categoryField`+`valueField`+`aggregate` query. A superRefine requires `values` when `dataset` is set. Existing inline widgets are unchanged. Completes the symmetric half of B-P1 (report + dashboard now both consume the governed dataset). Bumps .objectui-sha to the matching objectui commit (DatasetWidget renders dataset-bound widgets via queryDataset). Tests: dashboard.test +3 (dataset-bound valid; missing values rejected; legacy inline still valid). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive dual-form DashboardWidgetSchema: a widget may bind a dataset + dimensions + values instead of inline object query; superRefine enforces values when dataset set. Completes the symmetric half of B-P1 (report + dashboard both consume the governed dataset). Bumps .objectui-sha to matching objectui commit (#1576). Tests: dashboard.test +3. Verified live in Studio.
🤖 Generated with Claude Code