feat(spec): report can bind to a dataset (ADR-0021 B-P1, dual-form)#1646
Merged
Conversation
Additive dual-form for ReportSchema: a report may now reference a semantic-layer `dataset` and pick `rows` (dimension names) + `values` (measure names) + `runtimeFilter`, INSTEAD of the inline `objectName` + `columns` query. `objectName`/`columns` become optional; a superRefine enforces exactly one shape (dataset+values, or objectName+columns). Existing inline reports are unchanged and still validate. This is the value unlock for ADR-0021: report/dashboard consume the governed dataset (one definition of every metric) instead of re-declaring a query inline. Also bumps .objectui-sha to the matching objectui commit (ReportPreview renders dataset-bound reports via queryDataset). Tests: report.test +5 (dataset-bound valid; missing values rejected; legacy inline still valid; missing objectName/columns rejected; runtimeFilter carried). Verified live: a dataset-bound report renders its table (revenue by stage) in the Studio preview. Note: client-side validation in the Studio editor recognises the new shape only after objectui bumps its @objectstack/spec dependency (cross-repo spec skew); rendering already works because the preview reads draft fields directly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive dual-form ReportSchema: a report may bind a
dataset+rows/values/runtimeFilterinstead of inlineobjectName+columns. superRefine enforces one shape; existing inline reports unchanged. The value unlock for ADR-0021 (report consumes the governed dataset). Bumps .objectui-sha to the matching objectui commit (#1573). Tests: report.test +5. Verified live: dataset-bound report renders revenue-by-stage table in Studio preview.Note: Studio editor client validation recognises the new shape only after objectui bumps @objectstack/spec (cross-repo skew); rendering already works.
🤖 Generated with Claude Code