docs(adr): ADR-0034 robust multi-write transactions (diagnosis + fix plan)#1606
Merged
Merged
Conversation
…ion) Diagnoses the multi-write transaction deadlock found while implementing the cross-object atomic batch (#1604): knex+sqlite single-connection contention because internal queries during a write don't reuse the transaction's connection. Specifies the fix (AsyncLocalStorage ambient transaction + per-transaction connection), notes driver-sql already has a persistent sequence (so #1603 consolidates rather than rebuilds), and a cross-driver multi-write test plan. Foundation for #1603/#1604. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundation for #1603/#1604. Documents the multi-write transaction deadlock (knex+sqlite single-connection contention: internal queries during a write don't reuse the transaction's connection) and the fix: AsyncLocalStorage ambient transaction + per-transaction connection, with a cross-driver multi-write test plan. Also notes driver-sql already has a persistent atomic sequence, so #1603 consolidates rather than rebuilds. Docs-only.
🤖 Generated with Claude Code