docs(adr): ADR-0030 notification platform convergence (supersedes 0012)#1432
Merged
Merged
Conversation
…2) + build spec Records the decision to converge the two drifted, overlapping inbox objects (sys_notification, sys_inbox_message) by un-conflating them back into ADR-0012's layered pipeline under a single `emit()` ingress — rather than merging into one table. - docs/adr/0030-notification-platform-convergence.md — the decision: drift finding + evidence, single-ingress rule, target object model (L2 event / L3 resolve+preference / L4 delivery outbox / L5 materialize+receipt), resolved design decisions, phased plan P0–P3. - docs/design/notification-platform-convergence.md — the executable build spec: table schemas, `emit()` contract, per-phase tasks with file/package targets + acceptance criteria, migration sequencing, open decisions, risks. - ADR-0012 status line marked "Superseded by ADR-0030" (body left intact as the historical draft). Handoff artifact for the agent implementing the notification work; no code changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Handoff artifact for the agent implementing the notification work. No code changes.
Documents the decision to fix the two drifted, overlapping in-app inbox objects —
sys_notification(UI-read, written directly by collaboration) andsys_inbox_message(written by thenotifynode, zero readers) — by un-conflating them back into ADR-0012's layered pipeline under a singleemit()ingress, rather than merging into one table.docs/adr/0030-notification-platform-convergence.md— the decision: drift finding + evidence, the single-ingress rule, the target object model (L2 event / L3 resolve+preference / L4 delivery outbox / L5 materialize+receipt), resolved design decisions, phased plan P0–P3.docs/design/notification-platform-convergence.md— the executable build spec: table schemas,emit()contract, per-phase tasks with file/package targets + acceptance criteria, migration sequencing, open decisions, risks.docs/adr/0012-notification-platform.md— status line marked Superseded by ADR-0030 (body left intact as the historical draft).Why a new ADR (not editing 0012)
0012 is a Draft that drifted in implementation; 0030 is a genuinely new decision (un-conflate + single ingress + phased realization) and supersedes it, preserving the audit trail and the references from ADR-0019/0022. Numbered 0030 because 0028/0029 were taken by #1431.
Context
Findings from this session's end-to-end automation testing (PRs #1426/#1429/#1430): the
notifyflow node delivers tosys_inbox_message, but the Console bell only readssys_notification, so notify-based notifications never surface in the UI. The root cause is a violated principle — producers writing per-user inbox rows directly with no pipeline.🤖 Generated with Claude Code