RFC 6749#4.1.2.1 - fix order of error handling#565
Open
kiebzak wants to merge 2 commits intooauthjs:masterfrom
Open
RFC 6749#4.1.2.1 - fix order of error handling#565kiebzak wants to merge 2 commits intooauthjs:masterfrom
kiebzak wants to merge 2 commits intooauthjs:masterfrom
Conversation
According to https://tools.ietf.org/html/rfc6749#section-4.1.2.1 once the redirect_uri & client_id is correct authorization server should inform the clinet, that user denied access. The change is to move validation of resource owner approval after the redirect_uri & client identifier validation so the correct redirect url is computed
thomseddon
force-pushed
the
master
branch
2 times, most recently
from
08f0399 to
b84778b
Compare
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://tools.ietf.org/html/rfc6749#section-4.1.2.1, only when the
redirect_uri&client_idwere correct, the authorisation server should inform the client that user had denied access.The change is to move validation of resource owner approval after the
redirect_uri&client_idvalidation so the correct redirect url is computed.