dependencies: upgrade ginkgo to v2#6
Merged
tuunit merged 2 commits intooauth2-proxy:mainfrom Mar 29, 2025
Merged
Conversation
Contributor
Author
|
Cc: @tuunit This is somewhat related to oauth2-proxy/oauth2-proxy#2982 : this is also a dependency cleanup. |
tuunit
requested changes
Mar 19, 2025
Upgrade ginko to v2: 1. go get github.com/onsi/ginkgo/v2@latest 2. go get github.com/onso/gomega@latest 3. Fix reference-gen/*_test.go to use ginkgo/v2 4. go mod tidy 4. go get k8s.io/klog/v2@latest # fix nil logger errors 5. go mod tidy 6. go mod edit -go=1.23 # instead of 1.23.0 7. go mod tidy
The "toolchain go1.24.1" had been automatically added in go.mod. Let's downgrade to match the "go" directive. go mod edit -toolchain=go1.23.7
dolmen
force-pushed
the
upgrade-ginkgo-to-v2
branch
from
9652043 to
891ac1c
Compare
Contributor
Author
|
@tuunit reference-gen/go.mod now requires only Go 1.23. |
tuunit
approved these changes
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ginko to v2
Description
go get github.com/onsi/ginkgo/v2@latestgo get github.com/onso/gomega@latestreference-gen/*_test.goto useginkgo/v2go mod tidygo get k8s.io/klog/v2@latest# fix nil logger errorsgo mod tidygo mod edit -go=1.23# instead of 1.23.0go mod tidyMotivation and Context
Dependencies are outdated. Those dependencies are affecting the go.mod of
oauth2-proxy. Among others, they bring a dependency ongopkg.in/yaml.v2.How Has This Been Tested?
go test ./...