TW-5091: nullable calendar color id fix#325
Open
googsvg wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
============================================
+ Coverage 82.49% 82.74% +0.25%
- Complexity 358 361 +3
============================================
Files 38 39 +1
Lines 1034 1055 +21
Branches 95 99 +4
============================================
+ Hits 853 873 +20
Misses 122 122
- Partials 59 60 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PlayerZero
Change SummaryTW-5091: nullable calendar color ID fix
updated: May 19 @ 07:51 PM UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #324
Introduces
NullableField<T>to model three serialization states (omit / set / explicit null),and adds
UpdateEventRequest.Builder.clearColorId()which sends"color_id": nullto the API.Previously there was no way to clear an event color — null fields were silently dropped by Moshi.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.