Conversation
4972521 to
3a6229a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the BackButtonManager project from .NET 8 to .NET 10, including all dependencies, build tools, and language versions. This is a major breaking change as indicated in the metadata.
Key changes:
- Updates all target frameworks from
net8.0tonet10.0and mobile/Windows variants - Updates C# LangVersion from 12.0 to 14.0
- Updates all package dependencies to versions compatible with .NET 10, including Microsoft.Extensions, testing frameworks, and Uno.WinUI
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BackButtonManager/BackButtonManager.csproj | Updates LangVersion to 14.0 and dependency packages (Microsoft.Extensions.Logging.Abstractions, Microsoft.SourceLink.GitHub) |
| src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj | Updates target frameworks to net10.0, changes SDK from MSBuild.Sdk.Extras to Microsoft.NET.Sdk, updates Windows SDK target, and updates Uno.WinUI and other dependencies |
| src/BackButtonManager.Uno.WinUI/winappsdk-workaround.targets | Updates Windows SDK version reference in comment from 19041 to 20348 |
| src/BackButtonManager.Tests/BackButtonManager.Tests.csproj | Updates target framework to net10.0, LangVersion to 14.0, and all testing dependencies (coverlet, xunit, Moq, FluentAssertions, Microsoft.NET.Test.Sdk) |
| src/BackButtonManager.Abstractions/BackButtonManager.Abstractions.csproj | Updates LangVersion to 14.0 and dependency packages |
| build/stage-build.yml | Updates .NET SDK version to 10.0.100 and UnoCheck version and manifest |
| build/azure-pipelines.yml | Updates Windows hosted agent image from windows-2022 to windows-2025 |
| BREAKING_CHANGES.md | Documents the .NET 8 to 10 update as version 4.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj
Outdated
Show resolved
Hide resolved
src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj
Outdated
Show resolved
Hide resolved
3a6229a to
82c372a
Compare
Marc-Antoine-Soucy
approved these changes
Jan 7, 2026
725b604 to
fd8aecb
Compare
Contributor
Author
|
I have an issue with the Mac OS workload; I think I will remove it. |
fd8aecb to
a3d93d8
Compare
jeanplevesque
requested changes
Jan 14, 2026
a3d93d8 to
a7ae8b0
Compare
jeanplevesque
approved these changes
Jan 20, 2026
a7ae8b0 to
2a241af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
What is the current behavior?
Targets .NET 8.
Targets Uno 5.
What is the new behavior?
Targets .NET 10.
Targets Uno 6.
Removed support for Mac OS.
Impact on version
buildfolder was changed..githubfolder was changed.Checklist
Please check that your PR fulfills the following requirements:
Documentation has been added/updated.Automated Unit / Integration tests for the changes have been added/updated.Other information