Skip to content

feat: build @nuxt/module-builder using rolldown #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DamianGlowala wants to merge 15 commits into
base: main
Choose a base branch
from
+343 −32
Open

feat: build @nuxt/module-builder using rolldown #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cf23fac
feat: build `@nuxt/module-builder` using rolldown
Apr 30, 2026
4280a6f
update lint scripts
Apr 30, 2026
ff16b61
lint
Apr 30, 2026
52960e6
add .eslintcache to .gitignore
Apr 30, 2026
618df4e
add explicit tinyglobby dep
Apr 30, 2026
222c9d1
update engines
Apr 30, 2026
b8dd9cf
update external and input rolldown opts
DamianGlowala May 1, 2026
728c1ed
remove tinyglobby dep
DamianGlowala May 1, 2026
56e4fd5
udpate regex
DamianGlowala May 1, 2026
75bfbbb
simplify regex
DamianGlowala May 1, 2026
bcf6982
fix regex
DamianGlowala May 1, 2026
00f8542
use rolldown v1.0.0
May 7, 2026
a1d5841
Merge branch 'main' into feat/rolldown
May 7, 2026
f718fb5
remove node 22 (EOL) from engines
May 7, 2026
53e3d0c
Merge branch 'main' into feat/rolldown
DamianGlowala May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ package-lock.json
.idea/
example/playground/.nuxtrc
.temp*
.eslintcache
9 changes: 0 additions & 9 deletions build.config.ts
View file
Open in desktop

This file was deleted.

12 changes: 8 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@
"dist"
],
"scripts": {
"build": "unbuild",
"dev:prepare": "unbuild --stub && pnpm -r dev:prepare",
"build": "rolldown -c",
"build:watch": "pnpm build -w",
"dev:prepare": "pnpm -r dev:prepare",
"example:build": "pnpm nuxt-module-build build ./example",
"example:stub": "pnpm nuxt-module-build build --stub ./example",
"lint": "eslint .",
"lint": "eslint . --cache",
"lint:fix": "eslint . --cache --fix",
"nuxt-module-build": "JITI_ESM_RESOLVE=1 jiti ./src/cli.ts",
"prepack": "pnpm build",
"release": "pnpm vitest run && pnpm build && changelogen --release && pnpm publish && git push --follow-tags",
Expand All @@ -53,6 +55,8 @@
"mlly": "^1.8.2",
"pathe": "^2.0.3",
"pkg-types": "^2.3.1",
"rolldown": "^1.0.0",
"rolldown-plugin-dts": "^0.23.2",
"tsconfck": "^3.1.6",
"unbuild": "^3.6.1",
"vue-sfc-transformer": "^0.1.17"
Expand Down Expand Up @@ -85,6 +89,6 @@
"vue-tsc": "^3.2.8"
},
"engines": {
"node": "^18.0.0 || >=20.0.0"
"node": ">=22.12.0"
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

rolldown 1.0.0 Node.js version requirements

💡 Result:

Rolldown 1.0.0’s Node.js version requirement (from Rolldown’s official dev documentation) is: Node.js >= 24.12.0 (minimum). It also states that the project requires Node.js and pnpm (for dependency management). [1] Explanation / where this comes from: - The “Setup the project” guide for Rolldown explicitly says: “Install Node.js >= 24.12.0 / 21.2.0” and “Make sure to install and use Node.js version 24.12.0+ (which is the minimum requirement for this project).” [1] Notes: - The docs describe this as the minimum requirement for building/installing Rolldown’s npm package from source/dev environment. They do not provide a separate, different Node.js requirement specifically labeled “rolldown 1.0.0”, but 1.0.x is the stable line and uses the same npm/N-API-RS packaging approach described in the setup guide. [1]

Citations:

Update Node.js engine requirement to >= 24.12.0.

The engine requirement is set to >=22.12.0, but Rolldown 1.0.0 actually requires Node.js >= 24.12.0 according to the official documentation. Update package.json line 92 to reflect the correct minimum version.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 92, The package.json engines field currently sets
"node" to ">=22.12.0" but Rolldown 1.0.0 requires Node >=24.12.0; update the
engines entry (the "node" value) to ">=24.12.0" so the package declares the
correct minimum Node.js version.

}
}
Loading
Loading