Skip to content

Conversation

@AucaCoyan
Copy link
Contributor

@AucaCoyan AucaCoyan commented Dec 26, 2024

When I updated nu to 101, the completions of poetry failed because of a missing :
this

def "nu-complete poetry python-versions" [] nothing -> list<string> {

for this

def "nu-complete poetry python-versions" []: nothing -> list<string> {

Fixed a couple of places and some other parser issues

@AucaCoyan AucaCoyan changed the title 🐛 fix poetry completions 🐛 fix some parser issues with type signatures Dec 26, 2024
@AucaCoyan
Copy link
Contributor Author

I recently made a breaking change in [9c80b6b], I had to make a main function in order to be able to import the script from another place.
It's not imported anywhere in this repo, but probably the user will note some changes

@AucaCoyan
Copy link
Contributor Author

and finally, I don't know how to solve the permission issue on the CI:

lint: ❌ /home/runner/work/nu_scripts/nu_scripts/modules/cwdhist/mod.nu has errors:
╭───┬──────────┬───────────────────────────────────────────────────────────────╮
│ # │ severity │                            message                            │
├───┼──────────┼───────────────────────────────────────────────────────────────┤
│ 0 │        1 │ Error:                                                        │
│   │          │   × Problem with                                              │
│   │          │ [/home/runner/.cache/nu_cwd_history.sqlite], Permission       │
│   │          │   │                                                           │
│   │          │ denied                                                        │
│   │          │     ╭─[/home/runner/work/nu_scripts/nu_scripts/modules/       │
│   │          │ cwdhist/mod.nu:80:32]                                         │
│   │          │  79 │     if not ($env.cwd_history_file                       │
│   │          │ | path exists) {                                              │
│   │          │  80 │         empty-sqlite | save -f                          │
│   │          │ $env.cwd_history_file                                         │
│   │          │     ·                                                         │
│   │          │ ──────────┬──────────                                         │
│   │          │     ·                                                         │
│   │          │        ╰── No such file or directory (os error 2)             │
│   │          │  81 │                                                         │
│   │          │   open $env.cwd_history_file | query db "create table if not  │
│   │          │ exists cwd_history (                                          │
│   │          │     ╰────                                                     │
│   │          │                                                               │
│   │          │                                                               │
╰───┴──────────┴───────────────────────────────────────────────────────────────╯

Can I have some help here? 🙏 Should I revert the changes? Can I fix the problem? Should we merge as is?

@AucaCoyan AucaCoyan marked this pull request as ready for review December 26, 2024 14:57
@fdncred
Copy link
Contributor

fdncred commented Dec 26, 2024

I don't trust the CI script and wouldn't worry about it.

@fdncred fdncred merged commit 4fa48b3 into nushell:main Dec 26, 2024
1 check failed
@fdncred
Copy link
Contributor

fdncred commented Dec 26, 2024

Thanks

@AucaCoyan
Copy link
Contributor Author

To you!

@AucaCoyan AucaCoyan deleted the fix-type-signatures branch December 26, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants