Skip to content

~150x-300x faster downloads with numerapi #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndharasz merged 1 commit into from
Jun 2, 2026
+4 −2
Merged

~150x-300x faster downloads with numerapi #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions numerapi/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

logger = logging.getLogger(__name__)

DOWNLOAD_CHUNK_SIZE = 1024 * 1024 # 1 MiB


def load_secrets() -> tuple:
"""load secrets from environment variables or dotenv file"""
Expand Down Expand Up @@ -96,9 +98,9 @@ def download_file(url: str, dest_path: str, show_progress_bars: bool = True):
# Update progress bar to reflect how much of the file is already downloaded
pbar.update(file_size)
with open(temp_path, "ab") as dest_file:
for chunk in req.iter_content(1024):
for chunk in req.iter_content(DOWNLOAD_CHUNK_SIZE):
dest_file.write(chunk)
pbar.update(1024)
pbar.update(len(chunk))
# move temp file to target destination
os.replace(temp_path, dest_path)
return dest_path
Expand Down
Loading