Skip to content

fix(nsgotest): wait for style transitions to end - #643

Draft
houko wants to merge 1 commit into
mainfrom
fix/nsgotest-transition-settle
Draft

houko wants to merge 1 commit into
mainfrom
fix/nsgotest-transition-settle

Conversation

@houko

@houko houko commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make nsgotest steps advance pending style-transition end timers
  • ensure OnTransitionEnd and popup exit callbacks run before a step returns
  • preserve ManualFrames for tests that inspect transitions in progress
  • add regression coverage and update testing documentation

Closes #335

Verification

  • go tool nsgo check
  • go tool nsgo test

@github-actions github-actions Bot added documentation Improvements or additions to documentation core base ui bug Something isn't working size/S labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base bug Something isn't working core documentation Improvements or additions to documentation size/S ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nsgotest: steps do not wait for style transitions to end (OnTransitionEnd, base.Dialog EndingStyle)

1 participant