Repository navigation
Conversation
houko
force-pushed
the
fix/touch-presentation-coordinates
branch
from
November 18, 2026 02:43
934db13 to
343931f
Compare
The Android CI emulator is 320 points wide, so a 400-point camera put its zoom button off screen and the test could not press it. Use a 300-point camera with smaller content, as the package's other tests stay within 320 points.
houko
force-pushed
the
fix/touch-presentation-coordinates
branch
from
November 18, 2026 04:03
343931f to
38bb88b
Compare
CodeQL flagged converting strconv.Atoi's int to the 32-bit NodeID without a bound check. Parse the view id with ParseUint at 32 bits, as the target id already is.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touch handlers inside a panned or zoomed camera currently receive positions from the committed layout, even though the native view has moved. Capture the native hit target and each listening view's current local coordinates on the platform thread, then carry that snapshot through capture, bubbling, responder negotiation and responder callbacks. A responder keeps receiving coordinates for every remaining finger after its original finger lifts.
Implement snapshots on macOS, iOS, Android, Windows, Linux and the web, and use the bound-transform model in headless tests. Refresh Android transform origins after native layout so a camera mounted before its views have dimensions draws and receives input at the intended coordinates. Rebuild the committed Android runtime. Document the remaining HarmonyOS, mini program and watchOS gaps.
Closes #519.
Validation (after rebasing onto current main):
TestTouchCoordinatesFollowTheCameraandTestTouchMovesFollowNestedBoundTransformspass on macOS, the iOS simulator, an Android API 35 emulator, Windows 11, Linux/X11 (Xvfb) and the web. The wholeinternal/testhost/testdata/presspackage passes on Android, Linux and the web, and headless.go tool nsgo test -run 'Layer|Skills|Doc' .passes.go tool nsgo check -target allpasses for macOS, Windows, Linux, Android and the web, and for ios, ios_simulator, tvos_simulator and watchos_simulator on a Mac with Xcode.