Repository navigation
Conversation
houko
force-pushed
the
fix/peer-class-diagnostics
branch
from
November 17, 2026 17:54
8b95dcb to
cf60bf9
Compare
houko
force-pushed
the
fix/peer-class-diagnostics
branch
from
November 18, 2026 00:48
cf60bf9 to
ce6ba53
Compare
houko
force-pushed
the
fix/peer-class-diagnostics
branch
from
November 18, 2026 03:02
ce6ba53 to
10e8683
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
peer-*variant in a span's classes orScreen.HeaderClassparsed successfully but could never match because those contexts have no sibling matcher. The rule failed silently.Report each unsupported peer class once per context through the graph's bounded diagnostic cache, while preserving the existing unknown-class diagnostics. Run the same check when theme changes reparse spans. Leave shared parsed lists intact, so using the same class string on an ordinary sibling view still works.
The styles guide (English and Chinese), the architecture notes, the agent skill's authoring reference, the
Span.Class/Screen.HeaderClassdoc comments and the TSXheaderClasstype doc say where peer variants do not apply and to put a span's peer variant on itsText.Closes #553.
Verification (rebased onto current main):
SpansFuncupdates, and reparsing after theme replacement. Each context logs only once; ordinary span/header styles and a Text's own peer-dependent style remain intact.go tool nsgo test ./core(718 passed),go tool nsgo test ./tsxandgo tool nsgo test -run 'Layer|Skills|Doc' .(35 passed) pass.go build ./...,go vet ./core ./tsxfor linux, windows, android/arm64, js/wasm and darwin,go vet ./corefor ios, andgo tool nsgo check -target allpass.This is shared core behavior on every backend (a log line, no rendering change); no platform-specific API changes are needed.