Repository navigation
Conversation
houko
force-pushed
the
fix/android-tabbar-insets
branch
from
November 17, 2026 17:44
4bd52cf to
c988d8b
Compare
houko
force-pushed
the
fix/android-tabbar-insets
branch
from
November 18, 2026 01:43
c988d8b to
a31c581
Compare
houko
force-pushed
the
fix/android-tabbar-insets
branch
from
November 18, 2026 03:03
34ec531 to
ce3a1a1
Compare
houko
force-pushed
the
fix/android-tabbar-insets
branch
from
November 18, 2026 03:43
ce3a1a1 to
db923ff
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android tab bars subtracted the window's entire bottom navigation inset even when placed in the middle of the screen. With three-button navigation this left only 32 points of an 80-point bar, clipping its icons and titles.
Compute the bar's actual overlap with the navigation region, use only that overlap as bottom padding, and report the resulting natural height back to Go through the existing native-component event bridge. The overlap is recalculated from a global layout listener after every layout pass of the window, so a move of the bar or of any ancestor updates it, and a padding change takes effect on the next pass instead of requesting layout from inside
onLayout. Explicit heights remain authoritative and IME insets are excluded. Regenerate the prebuilt Android runtime.Closes #591.
Verification (current revision, rebased onto main at 861c49d):
TestTabBarSVGNativeTint,TestTabBarNativeInsetsFollowPlacementandTestTabBarItemsEncodeCanvasIconspassed. The placement test checks height and icon/label pixels for a bar in the middle, against the bottom, above navigation, partly overlapping navigation, and moved back to the middle.TabBar.java,tabbar.go,classes.dexandclasses.jar,TestTabBarSVGNativeTintandTestTabBarNativeInsetsFollowPlacementfail (icon pixel shows only the bar surface).classes.dex,classes.jarandtabbar.go, both tab-bar native tests fail on three-button navigation (icon pixel shows only the bar surface), so the tests cover the bug.go build ./..., windows/linux/js-wasm builds,GOOS=android GOARCH=arm64 go vet ./internal/platform/android,go tool nsgo check -target all(Apple targets need Xcode and were skipped on the Linux host),go tool nsgo test ./internal/platform/android(all host tests pass; native tests skip without their target) andgo tool nsgo test -run 'Layer|Skills|Doc' .(35 passed).classes.dexandclasses.jarwithinternal/platform/android/runtime/build.shon top of main's Java runtime; the rebuild is reproducible at the branch head.The existing SVG regression now fits the actual viewport and uses
Scope.Postto change its selection on the engine goroutine. Reviewed iOS's native tab-bar sizing and recorded its separate one-time-measurement limitation in the roadmap; this PR changes no iOS behaviour.