Repository navigation
Catch forgotten definitions and catch up with the BEAM servers - #24
Merged
Merged
Conversation
session.persistent evaluated a definition and then its use, which passes on a server that keeps only the definitions each eval touches. repartee did just that (evals ran with Elixir's prune_binding), so after `x = 1` and `y = 2` its sessions had lost `x`. The check evaluates the value snippet in between now.
The profile had no multiple snippet, so eval.multiple-forms always skipped, and repartee sending only the last value went unnoticed.
nrepl-beam fixed close, unknown-op and multiple values in October, and stderr and repartee's values in November, but proof serve still did all of it for -like dialtone and -like repartee, and the test that keeps the presets in line with the matrix expected it too. Neither server has a scenario left, which proof list shows as none, and the docs and the notes on the spec say what they do now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session.persistentnow evaluates something else between a definition and its use, which is what it takes to catch a server that keeps only what each eval touches, like repartee did. The repartee profile gets amultiplesnippet, soeval.multiple-formsruns there instead of skipping. And with nrepl-beam's fixes merged,-like dialtoneand-like reparteehave no scenarios left, so they act like nREPL.