Repository navigation
Add client profiles for clojure-cli.repl and bb repl --connect - #20
Merged
Merged
Conversation
bb repl --connect clones a session and asks for describe before its first prompt, and reads the ops and versions in the reply as dicts. Its evals have nothing but the code and the session, which eval.value covers already. clojure-cli.repl is meant for the server that comes with it, but its client works with others too, where its own ops (e.g. watch) get unknown-op. It evaluates code with the namespace of its prompt. Both were recorded with proof proxy against Babashka. That's also how clojure-cli.repl 0.2.3 turned out to still leave need-input unanswered and never close its session, which are its own problems rather than the server's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every server in the matrix passes both. They're here so the report names these clients when a server breaks them.