Repository navigation
fix: stop i18n:check adding empty keys - #3392
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Synchronise and prune empty locale entries scripts/compare-translations.ts, i18n/locales/*.json |
syncLocaleData omits empty nested results even when fix mode is disabled. Locale files remove empty placeholders. The Chinese (Simplified) deprecated translation moves into package.timeline.chart, and the Portuguese (Portugal) locale adds alt_logo_kawaii. |
Suggested reviewers: alexdln
Merge Risk: 
Minimal · up to 5135c
-
The change prevents empty translation placeholders from being retained during synchronisation. No merge-blocking issue is established; merge after normal checks pass.
Pre-merge checks: 
4
-
Full details: Linked Issues check
-
Explanation
Issue
#3391requiresi18n:checkto stop creating empty locale objects after reference keys are removed. Inscripts/compare-translations.ts,syncLocaleDatanow deletes a nested result when it has no keys, without requiring--fix. The changed locale files remove the resulting empty placeholders. No separate coding acceptance criteria or required automated tests are stated in issue#3391.
Full details: Out of Scope Changes check
-
Explanation
The changes remain within issue
#3391. The locale edits remove empty entries produced by the translation synchronisation, and thezh-CNedit preserves an existing translation at the reference structure. No unrelated runtime behaviour or unrelated files are changed.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
i18n:check adding empty keysi18n:check adding empty keys
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
336c921 to
5135c5b
Compare
i18n:check adding empty keysi18n:check adding empty keys
trueberryless
left a comment
There was a problem hiding this comment.
Amazing, looks perfect to me 🙌
🔗 Linked issue
Closes #3391
🧭 Context
📚 Description