Skip to content

feat: draft menu redesign - #3248

Draft
alexdln wants to merge 1 commit into
npmx-dev:mainfrom
alexdln:feat/menu-draft
Draft

alexdln wants to merge 1 commit into
npmx-dev:mainfrom
alexdln:feat/menu-draft

Conversation

@alexdln

@alexdln alexdln commented Sep 13, 2026

Copy link
Copy Markdown
Member

🧭 Context

A mostly generated PR with the idea of ​​a header redesign - the header feels overloaded to me now. For now, this is a rough draft with some minor refactors. If the idea seems viable, I'll make a new one with a clean implementation

image image

@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Sep 13, 2026 1:07pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Sep 13, 2026 1:07pm UTC
npmx-lunaria Ignored Ignored Sep 13, 2026 1:07pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3167 2 3165 21
View the top 2 failed test(s) by shortest run time
test/unit/a11y-component-coverage.spec.ts > a11y component test coverage > should have accessibility tests for all components (or be explicitly skipped)
Stack Traces | 0.0176s run time
AssertionError: Missing a11y tests for 1 component(s):
  - MenuDropdown.vue

To fix: Add tests in test/nuxt/a11y.spec.ts or add to SKIPPED_COMPONENTS in test/unit/a11y-component-coverage.spec.ts with justification.: expected 1 to equal +0

- Expected
+ Received

- 0
+ 1

 ❯ test/unit/a11y-component-coverage.spec.ts:187:12
connector.spec.ts::Connector Connection › opens connector modal and shows connected user
Stack Traces | 6.03s run time
locator.click: Error: strict mode violation: locator('button[aria-haspopup="true"]') resolved to 2 elements:

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant