feat: package page to compare page carry the name#3030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughDesktop Compare links now include the current package when available. The package header’s inline compare button and shortcut are removed, and the ChangesPackage compare navigation cleanup
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Link/Base.vue`:
- Around line 39-40: Add a JSDoc comment describing the `name` prop in the
component props definition, and update the `NuxtLink` template using
`v-bind="props"` so `name` is explicitly overridden or omitted after the spread,
preventing it from being rendered as an `<a>` attribute.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: aeeb1ecc-2d7f-4d85-b0a1-97fa8adf26c1
📒 Files selected for processing (2)
app/components/AppHeader.vueapp/components/Link/Base.vue
|
I think I agree with this 👍 We currently have 2 
I would just remove the |
graphieros
added
the
needs discussion
|
I think we should go along with this PR, because it fits in the steps that are planned to improve the package page. |
|
Yes, this looks like a good step to me! |
| const keyboardShortcutsEnabled = useKeyboardShortcuts() | ||
| </script> | ||
|
|
||
| const { packageName } = usePackageRoute() |
There was a problem hiding this comment.
🤔 It seems smelly to me that the LinkBase component is aware of the package route and compare route and owns this logic. Could we try to move this up, similar to the existing "compare this package" button?
|
Personally, I don't feel strongly (please feel free to make a call without me here), but I have these thoughts:
Maybe the nav item could turn into a button group...? lazy mockup (imagine a better icon, etc.): 
💭 Maybe there's an opportunity to make this feature even better? Could we keep track of your most recently viewed packages and add those to that button group dropdown in order...? |
Might it be a page caching issue? I didn't see this feature before, but I saw it after refreshing the page, and it's quite obvious. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
I agree with @graphieros's suggestion and have made the changes accordingly, keeping only one top button. 👍 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/AppHeader.vue`:
- Around line 21-29: Define a single computed Compare route target using
packageName, then reuse it in both desktopLinks and the c keyboard shortcut so
clicking Compare and pressing c preserve the same package context. Remove the
duplicated inline route definitions while keeping the existing non-package
fallback.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a2482ebd-8452-475c-bda4-1a882230a119
📒 Files selected for processing (27)
app/components/AppHeader.vueapp/components/Package/Header.vuei18n/locales/ar-EG.jsoni18n/locales/bn-IN.jsoni18n/locales/cs-CZ.jsoni18n/locales/de.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/fr-FR.jsoni18n/locales/hi-IN.jsoni18n/locales/id-ID.jsoni18n/locales/it-IT.jsoni18n/locales/ja-JP.jsoni18n/locales/mr-IN.jsoni18n/locales/nb-NO.jsoni18n/locales/nl.jsoni18n/locales/pt-BR.jsoni18n/locales/pt-PT.jsoni18n/locales/ro-RO.jsoni18n/locales/ru-RU.jsoni18n/locales/sr-Latn-RS.jsoni18n/locales/tr-TR.jsoni18n/locales/uk-UA.jsoni18n/locales/vi-VN.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
💤 Files with no reviewable changes (14)
- i18n/locales/bn-IN.json
- i18n/locales/cs-CZ.json
- i18n/locales/en.json
- i18n/locales/de.json
- i18n/locales/it-IT.json
- i18n/locales/tr-TR.json
- i18n/locales/es.json
- app/components/Package/Header.vue
- i18n/locales/fr-FR.json
- i18n/locales/nb-NO.json
- i18n/locales/ru-RU.json
- i18n/locales/nl.json
- i18n/schema.json
- i18n/locales/ja-JP.json
5 participants
🔗 Linked issue
/
🧭 Context
Based on the current structure, if a user is on the package page and then clicks to jump to the compare page, I think it would be reasonable to compare the current package. Therefore, it would be more convenient to directly carry over the package name.
📚 Description